Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 197295
| Summary: | Review Request: perl-List-Compare | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Chris Weyl <cweyl> |
| Component: | Package Review | Assignee: | Jason Tibbitts <j> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | psabata |
| Target Milestone: | --- | Flags: | gwync:
fedora-cvs+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2006-07-02 19:17:30 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 163779, 1215575 | ||
|
Description
Chris Weyl
2006-06-29 23:50:02 UTC
Note that BuildRequires: perl is redundant; it is part of the default build root. Review: * package meets naming and packaging guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is correct. * license field matches the actual license. * license is open source-compatible. License text not included upstream. * source files match upstream: 205677fa8e207afedbf800673a3c14de List-Compare-0.33.tar.gz * latest version is being packaged. * BuildRequires are proper. * package builds in mock (development, x86_64). * rpmlint is silent. * final provides and requires are sane: perl(List::Compare) = 0.33 perl(List::Compare::Accelerated) perl(List::Compare::Base::_Auxiliary) = 0.33 perl(List::Compare::Base::_Engine) = 0.33 perl(List::Compare::Functional) = 0.33 perl(List::Compare::Multiple) perl(List::Compare::Multiple::Accelerated) perl-List-Compare = 0.33-0.fc6 = perl(:MODULE_COMPAT_5.8.8) perl(Carp) perl(List::Compare::Base::_Auxiliary) perl(List::Compare::Base::_Engine) perl(strict) * no shared libraries are present. * package is not relocatable. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * %clean is present. * %check is present and all tests pass: All tests successful. Files=28, Tests=22945, 4 wallclock secs ( 3.59 cusr + 0.47 csys = 4.06 CPU) * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no libtool .la droppings. * not a GUI app. APPROVED Imported and built for FC-4,5,devel. Thanks! Package Change Request ====================== Package Name: perl-List-Compare New Branches: el6 epel7 Owners: psabata InitialCC: perl-sig Git done (by process-git-requests). perl-List-Compare-0.49-1.el7,perl-Tangerine-0.15-1.el7,tangerine-0.16-1.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/perl-List-Compare-0.49-1.el7,perl-Tangerine-0.15-1.el7,tangerine-0.16-1.el7 perl-List-Compare-0.49-1.el6,perl-Tangerine-0.15-1.el6,tangerine-0.16-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/perl-List-Compare-0.49-1.el6,perl-Tangerine-0.15-1.el6,tangerine-0.16-1.el6 perl-Tangerine-0.15-1.el7, perl-List-Compare-0.49-1.el7, tangerine-0.16-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. perl-List-Compare-0.49-1.el6, perl-Tangerine-0.15-1.el6, tangerine-0.16-1.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report. |