Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 197476
Summary: | Review Request: python-cvstoys | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Michael J Knox <michael> |
Component: | Package Review | Assignee: | Jochen Schmitt <jochen> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | ||
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2006-07-06 19:32:01 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779 |
Description
Michael J Knox
2006-07-02 19:49:15 UTC
Good: + Tarball in SRPM match with upstream. + Local build works fine. + License OK. + rpmlint of source RPM ok. + Mock build works fine on FC-5 as root. Bad: - No verbatin license in %doc stanza - I think the Group should be Development/Tools - Why you set CFLAGS, when no binary file will be created - rpmlint have the following complaints to the binary RPM. E: python-cvstoys non-executable-script /usr/lib/python2.4/site-packages/cvstoys/setup.py 0644 E: python-cvstoys non-executable-script /usr/lib/python2.4/site-packages/cvstoys/loginfo.py 0644 E: python-cvstoys non-executable-script /usr/lib/python2.4/site-packages/cvstoys/clients/words.py 0644 Updated: Spec URL: http://www.knox.net.nz/~michael/python-cvstoys.spec SRPM URL: http://www.knox.net.nz/~michael/python-cvstoys-1.0.10-2.src.rpm There is no license file provided, upstream has been contacted. As for the rpmlint errors, I check other python packages and they were the same. (In reply to comment #2) > As for the rpmlint errors, I check other python packages and they were the same. However, they should be fixable by editing out the shellbangs from the files concerned, which would shut rpmlint up and make everyone happy :-) is that the correct way to fix it? this certainly isn't happening with existing python-* packages. (In reply to comment #4) > is that the correct way to fix it? Yes. The shellbangs are put there by the upstream developers so that they can run individual parts of the package on their own for debugging. Given that the files are not installed with exec permissions, this isn't something that an end user is going to be needing to do. > this certainly isn't happening with existing > python-* packages. Perhaps many reviewers are happy to let them go because it's not an important issue (true in itself), or because they don't know how to fix it, or because they think the fix clutters the spec file and is therefore worse than the problem itself? My view is that it's best to shut rpmlint up as much as is reasonably possible (some things just can't be fixed because the package wouldn't work if they were), so that rpmlint generates as little output as possible. The benefit of this is that any new issues that crop up with package version or rpmlint changes are less likely to be lost amongst a barrage of unimportant issues. OK, I will patch it up shortly. Only asked cuz I didn't know and its not been covered in the python packaging guidelines :) (In reply to comment #6) > OK, I will patch it up shortly. Only asked cuz I didn't know and its not been > covered in the python packaging guidelines :) It's not a python-specific thing; it happens quite often with perl modules too. OK, patched... rpmlint is rather quiet now :-) Updates: Spec URL: http://www.knox.net.nz/~michael/python-cvstoys.spec SRPM URL: http://www.knox.net.nz/~michael/python-cvstoys-1.0.10-3.src.rpm rpmlint is noew quite for the binary rpm. So I will APPROVE your package. awesome. Thank you. In devel now and building. |