Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 197736

Summary: Review Request: perl-DateTime-Format-Strptime
Product: [Fedora] Fedora Reporter: Steven Pritchard <steve>
Component: Package ReviewAssignee: Jason Tibbitts <j>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Package Reviews List <fedora-package-review>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhide   
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2006-07-08 16:44:21 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 163779, 193078    

Description Steven Pritchard 2006-07-05 21:27:41 UTC 
Spec URL: http://ftp.kspei.com/pub/steve/rpms/perl-DateTime-Format-Strptime/perl-DateTime-Format-Strptime.spec
SRPM URL: http://ftp.kspei.com/pub/steve/rpms/perl-DateTime-Format-Strptime-1.0700-1.src.rpm
Description:
This module implements most of strptime(3), the POSIX function that is the
reverse of strftime(3), for DateTime. While strftime takes a DateTime and a
pattern and returns a string, strptime takes a string and a pattern and
returns the DateTime object associated.
Comment 1 Jason Tibbitts 2006-07-06 22:42:41 UTC 
* source files match upstream:
   fcda7127b01dcad43ca7cf30be9a1dc6  DateTime-Format-Strptime-1.0700.tar.gz
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible.  License text included in package.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (development, x86_64).
* rpmlint is silent.
* noarch package; no debuginfo.
* final provides and requires are sane:
   perl(DateTime::Format::Strptime) = 1.0700
   perl-DateTime-Format-Strptime = 1.0700-1.fc6
  =
   perl(:MODULE_COMPAT_5.8.8)
   perl(Carp)
   perl(DateTime)
   perl(DateTime::Locale)
   perl(DateTime::TimeZone)
   perl(Exporter)
   perl(Params::Validate)
   perl(strict)
   perl(vars)
* %check is present and all tests pass:
   All tests successful.
   Files=7, Tests=373,  2 wallclock secs ( 1.30 cusr +  0.15 csys =  1.45 CPU)
* no shared libraries are present.
* package is not relocatable.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no libtool .la droppings.
* not a GUI app.

APPROVED
Comment 2 Steven Pritchard 2006-07-08 16:44:21 UTC 
Imported into CVS, branches created, and builds requested.