Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 197739
| Summary: | Review Request: perl-DateTime-Event-Recurrence | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Steven Pritchard <steve> |
| Component: | Package Review | Assignee: | Jason Tibbitts <j> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | ||
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2006-07-13 20:33:32 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 197726 | ||
| Bug Blocks: | 163779, 197744 | ||
|
Description
Steven Pritchard
2006-07-05 21:36:26 UTC
Your two manual versioned dependencies are duplicated by unversioned dependencies found by RPM; you will have to remove yours or filter RPM's. Review: * source files match upstream: 9a08830b081a93619f4a8564063e3bf0 DateTime-Event-Recurrence-0.16.tar.gz * package meets naming and packaging guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is correct. * license field matches the actual license. * license is open source-compatible. License text included in package. * latest version is being packaged (0.16 12 May 2005) * BuildRequires are proper. * %clean is present. * package builds in mock (development, x86_64) (with DateTime-Set and Set-Infinite in my local repo) * rpmlint is silent. * noarch package, so no debuginfo. X final provides and requires are sane: perl(DateTime::Event::Recurrence) = 0.16 perl(DateTime::Set::ICal) perl-DateTime-Event-Recurrence = 0.16-1.fc6 = perl(:MODULE_COMPAT_5.8.8) X perl(DateTime) X perl(DateTime) >= 0.27 X perl(DateTime::Set) X perl(DateTime::Set) >= 0.17 perl(DateTime::Span) perl(Params::Validate) perl(constant) perl(integer) perl(strict) perl(vars) * %check is present and all tests pass: All tests successful. Files=14, Tests=195, 16 wallclock secs (15.10 cusr + 0.35 csys = 15.45 CPU) * no shared libraries are present. * package is not relocatable. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no libtool .la droppings. * not a GUI app. (In reply to comment #1) > Your two manual versioned dependencies are duplicated by unversioned > dependencies found by RPM; you will have to remove yours or filter RPM's. I dropped the manual dependencies. http://ftp.kspei.com/pub/steve/rpms/perl-DateTime-Event-Recurrence-0.16-2.src.rpm Looks good now. The dependency list is now: perl(:MODULE_COMPAT_5.8.8) perl(DateTime) perl(DateTime::Set) perl(DateTime::Span) perl(Params::Validate) perl(constant) perl(integer) perl(strict) perl(vars) APPROVED Imported into CVS, branches created, and builds requested. |