Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 197744

Summary: Review Request: perl-DateTime-Event-ICal
Product: [Fedora] Fedora Reporter: Steven Pritchard <steve>
Component: Package ReviewAssignee: Jason Tibbitts <j>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Package Reviews List <fedora-package-review>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhide   
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2006-07-13 20:35:09 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 197739    
Bug Blocks: 163779, 197745    

Description Steven Pritchard 2006-07-05 21:49:45 UTC
Spec URL: http://ftp.kspei.com/pub/steve/rpms/perl-DateTime-Event-ICal/perl-DateTime-Event-ICal.spec
SRPM URL: http://ftp.kspei.com/pub/steve/rpms/perl-DateTime-Event-ICal-0.09-1.src.rpm
Description:
This module provides convenience methods that let you easily create
DateTime::Set objects for rfc2445 style recurrences.

Comment 1 Jason Tibbitts 2006-07-08 02:51:35 UTC
* source files match upstream:
   a68e58f5aac48a739249118d078e9947  DateTime-Event-ICal-0.09.tar.gz
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible.  License text included in package.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (development, x86_64, some dependencies added to local
repo)
* rpmlint is silent.
* noarch package, so no debuginfo.
* final provides and requires are sane:
   perl(DateTime::Event::ICal) = 0.09
   perl-DateTime-Event-ICal = 0.09-1.fc6
  =
   perl(:MODULE_COMPAT_5.8.8)
   perl(Carp)
   perl(DateTime)
   perl(DateTime::Event::Recurrence) >= 0.11
   perl(DateTime::Set)
   perl(DateTime::Span)
   perl(DateTime::SpanSet)
   perl(Exporter)
   perl(Params::Validate)
   perl(constant)
   perl(strict)
   perl(vars)
* %check is present and all tests pass:
   All tests successful.
   Files=6, Tests=68, 111 wallclock secs (110.89 cusr +  0.23 csys = 111.12 CPU)
* no shared libraries are present.
* package is not relocatable.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no libtool .la droppings.
* not a GUI app.

APPROVED

Comment 2 Steven Pritchard 2006-07-13 20:35:09 UTC
Imported into CVS, branches created, and builds requested.