Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 197908

Summary:

Review Request: im-chooser - Input Method configuration tool

Product:

[Fedora] Fedora

Reporter:

Akira TAGOH <tagoh>

Component:

Package Review

Assignee:

Jens Petersen <petersen>

Status:

CLOSED NEXTRELEASE

QA Contact:

Fedora Package Reviews List <fedora-package-review>

Severity:

medium

Docs Contact:

Priority:

medium

Version:

rawhide

Target Milestone:

---

Target Release:

---

Hardware:

All

OS:

Linux

Whiteboard:

Fixed In Version:

Doc Type:

Bug Fix

Doc Text:

Story Points:

---

Clone Of:

Environment:

Last Closed:

2006-07-11 05:27:52 UTC

Type:

---

Regression:

---

Mount Type:

---

Documentation:

---

CRM:

Verified Versions:

Category:

---

oVirt Team:

---

RHEL 7.3 requirements from Atomic Host:

Cloudforms Team:

---

Target Upstream Version:

Embargoed:

Bug Depends On:

Bug Blocks:

163779

Attachments:

Description	Flags
im-chooser.spec-1.patch	none

Description Akira TAGOH 2006-07-07 05:11:03 UTC

Spec URL: http://people.redhat.com/tagoh/im-chooser/im-chooser.spec
SRPM URL: http://people.redhat.com/tagoh/im-chooser/im-chooser-0.2.0-1.src.rpm
Description:
im-chooser is a GUI configuration tool for Input Method that easily choose what you would use for your desktop.

Comment 1 Jens Petersen 2006-07-10 04:51:31 UTC

- rpmlint ok
- naming ok
! shouldn't use %makeinstall
- license is GPL and included in doc files
- md5sum is good
- builds fine on fc5 x86_64
- uses find_lang
! need desktop file and icon?
! doesn't build in mock:
checking for XML::Parser... configure: error: XML::Parser perl module is
required for intltool
! there seems to be a small bug in how it handles user-defined configs: if one
clicks on the selector showing "User defined", and then clicks somewhere else,
the selector changes to "scim" and a symlink to "User specific" is created.

I attach a spec file with some fixes.

Comment 2 Jens Petersen 2006-07-10 04:55:49 UTC

Created attachment 132157 [details]
im-chooser.spec-1.patch

Comment 3 Akira TAGOH 2006-07-10 10:35:53 UTC

Thanks. updated.

Spec URL: http://people.redhat.com/tagoh/im-chooser/im-chooser.spec
SRPM URL: http://people.redhat.com/tagoh/im-chooser/im-chooser-0.2.1-1.src.rpm

I can't reproduce the last comment however. if you have the exact steps to
reproduce it, it would be appreciated.

Comment 4 Jens Petersen 2006-07-10 11:28:16 UTC

(In reply to comment #3)
> I can't reproduce the last comment however. if you have the exact steps to
> reproduce it, it would be appreciated.

Ok, I don't think it is a blocking issue (it needs to be a file
not a symlink to reproduce it btw) and by "clicks somewhere
else" I meant clicking away from the selector to cancel any change
or clicking on "User defined" ("User specific").

Comment 5 Jens Petersen 2006-07-10 11:54:15 UTC

I get this error now in mock:

Making all in po
make[2]: Entering directory `/builddir/build/BUILD/im-chooser-0.2.1/po'
file=`echo ja | sed 's,.*/,,'`.gmo \
  && rm -f $file &&  -o $file ja.po
/bin/sh: -o: command not found
make[2]: *** [ja.gmo] Error 127

Otherwise the package looks good.

Comment 6 Jens Petersen 2006-07-10 11:58:31 UTC

I think you need to BR gettext for msgfmt.

Comment 7 Jens Petersen 2006-07-10 12:18:24 UTC

Feel to import it into extras cvs for more eyes to see it.
This is an important package for i18n.

Comment 8 Jens Petersen 2006-07-10 12:39:34 UTC

Builds ok in mock on fc5 with BR gettext.

Comment 9 Jens Petersen 2006-07-10 13:25:15 UTC

Thanks for the import.  APPROVED.

Comment 10 Akira TAGOH 2006-07-11 05:27:52 UTC

imported and built into devel.