Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 198021
Summary: | Review Request: perl-Log-Dispatch-Config | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Chris Weyl <cweyl> |
Component: | Package Review | Assignee: | Jason Tibbitts <j> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | negativo17, ppisar |
Target Milestone: | --- | Flags: | gwync:
fedora-cvs+
|
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2006-07-09 00:37:23 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779, 198023 |
Description
Chris Weyl
2006-07-08 03:52:05 UTC
Just a note that there's an empty line at the top of your .spec. * source files match upstream: 9d9b7b5d3426819e6b6e14e91b867242 Log-Dispatch-Config-1.01.tar.gz * package meets naming and packaging guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is correct. * license field matches the actual license. * license is open source-compatible. License text not included upstream. * latest version is being packaged. O BuildRequires are proper (BR: perl is not required). * %clean is present. * package builds in mock (development, x86_64). * rpmlint is silent. * noarch package, so no debuginfo. * final provides and requires are sane: perl(Log::Dispatch::Config) = 1.01 perl(Log::Dispatch::Configurator) = 1.00 perl(Log::Dispatch::Configurator::AppConfig) = 1.00 perl-Log-Dispatch-Config = 1.01-0.fc6 = perl(:MODULE_COMPAT_5.8.8) perl(AppConfig) perl(Log::Dispatch) >= 2.00 perl(Log::Dispatch::Configurator) perl(base) perl(strict) perl(vars) * %check is present and all tests pass: All tests successful. Files=15, Tests=48, 4 wallclock secs ( 0.68 cusr + 0.27 csys = 0.95 CPU) * no shared libraries are present. * package is not relocatable. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no libtool .la droppings. * not a GUI app. APPROVED * "...object with configulation file..." The upstream developer's summary used the word configulation, which is copied into the spec file. I don't think it's a real word. If it was changed to configuration, then package searches are more likely to be successful. Oops, my brain simply read over the typo. Time for a script to spellcheck Symmary: and %description, I suppose. Hm, I wonder if we can get rpmlint to do that. I glossed right over it, too... rpmlint does check for some common misspellings. It should be pretty easy to have it call aspell instead if it's installed. +Import to CVS +Add to owners.list +Bump release, build for devel +devel build succeeds +Request branching (FC-4, FC-5) +Close bug Thanks for the review! :) Package Change Request ====================== Package Name: perl-Log-Dispatch-Config New Branches: el6 Owners: slaanesh InitialCC: perl-sig Git done (by process-git-requests). |