Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 198198
Summary: | Review Request: ooo2txt - Convert OpenOffice documents to simple text | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Patrice Dumas <pertusus> |
Component: | Package Review | Assignee: | Jason Tibbitts <j> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | ||
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2006-07-15 09:43:47 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779 |
Description
Patrice Dumas
2006-07-10 13:36:30 UTC
Please post the .spec as a separate file. Having the .spec as a separate file makes it easier for people to look over the package and make comments without having to download the whole SRPM. spec file should be here soon: http://www.environnement.ens.fr/perso/dumas/fc-srpms/ooo2txt.spec Having the spec file may be usefull in some cases, but in that specific case I doubt it given that the spec is simple but there is no source packaged... It's always nice to be able to click on the spec to look at it the browser. I'll do a quick review in a bit. * source files match upstream: 3751eb30189c1d546aa404dff34954fa LGPL.txt 9f3c3794ba9ba61f6dc2c3b9465279ae ooo2txt.006.pl 1cd6103b0b9c49524438c2f17fede3a9 readme.txt ce95a6c73a221041321d9582276a5358 update.txt * package meets naming and packaging guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is correct. * license field matches the actual license. * license is open source-compatible. License text included in package. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (development, x86_64). * rpmlint is silent. * final provides and requires are sane: ooo2txt = 0.0.6-1.fc6 = /usr/bin/perl perl(Archive::Zip) perl(File::Temp) perl(Getopt::Std) perl(XML::Twig) perl(strict) * %check is not present; no test suite upstream. * no shared libraries are present. * package is not relocatable. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no libtool .la droppings. * not a GUI app. APPROVED Thanks, pushed and built. |