Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 198285
Summary: | Review Request: python-simplejson - Simple, fast, extensible JSON encoder/decoder for Python | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Luke Macken <lmacken> |
Component: | Package Review | Assignee: | John Mahowald <jpmahowald> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | j, pfrields |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2006-08-14 20:06:30 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779, 189338 |
Description
Luke Macken
2006-07-10 20:44:44 UTC
I'm not terribly well-versed in Python, but this looks to violate the guidelines: Python packages that use setuptools need to add python-setuptools as a BuildRequires and must either add --single-version-externally-managed to the line invoking setup.py in %install, or must add a .pth file containing the path to the egg or egg directory to %{python_sitelib}. I don't believe either of those are being done. In addition: E: python-simplejson zero-length /usr/lib/python2.4/site-packages/simplejson-1.3-py2.4.egg-info/zip-safe In general the packaging here looks odd. Why is the test suite included in the installed module, but not called at all by a %check section in the spec? What about the contents of /usr/lib/python2.4/site-packages/simplejson-1.3-py2.4.egg-info? Shouldn't this all be %doc, if it must be installed at all? http://people.redhat.com/lmacken/python-simplejson-1.3-2.src.rpm http://people.redhat.com/lmacken/python-simplejson.spec Added --single-version-externally-managed flag to setup.py install. The tests in the package all import the module itself, and are not setup to be run from the command line, so I think it would require way too much hassle (patches or much %{__python} -c uglyness) to deal with to get them running. As for the egg-info directory, I don't believe there is any policy on this, and every other python module I've seen packages up the directory and ignores the empty file warnings. rpmlint still says E: python-simplejson zero-length /usr/lib/python2.4/site-packages/simplejson-1.3-py2.4.egg-info/zip-safe I agree it can be ignored. Good: + sitelib macro + source matches + license (MIT) + mock builds on devel x86_64 + proper %clean section + macro usage throughout + noarch APPROVED Imported to CVS, added to owners.list, FC-5 branch requested, tagged and built for devel. Thanks! |