Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 198287
Summary: | Review Request: python-paste - Tools for using a Web Server Gateway Interface stack | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Luke Macken <lmacken> |
Component: | Package Review | Assignee: | Patrice Dumas <pertusus> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | pertusus, pfrields |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2006-07-19 20:17:00 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 198288, 198289 | ||
Bug Blocks: | 163779, 189338 |
Description
Luke Macken
2006-07-10 20:47:19 UTC
I had that for my Paste packaging attempt: # clean docs directory pushd docs rm StyleGuide.txt *.css */*.css rebuild doc.conf template.tmpl */*.js popd rpmlint has some errors that should certainly be fixed: E: python-paste non-executable-script /usr/lib/python2.4/site-packages/paste/util/scgiserver.py 0644 E: python-paste non-executable-script /usr/lib/python2.4/site-packages/paste/debug/doctest_webapp.py 0644 For scgiserver.py I believe it should be patched to have the shebang removed. For doctest_webapp.py it isn't obvious, maybe it can be run standalone, in that case the permissions should be fixed. There is an inconsistent use of RPM_BUILD_ROOT and %buildroot (also in other Paste related python packages) http://people.redhat.com/lmacken/python-paste.spec http://people.redhat.com/lmacken/python-paste-0.9.3-2.src.rpm * Sat Jul 15 2006 Luke Macken <lmacken> - 0.9.3-2 - Clean up docs directory - Remove shebang from from non-executable scripts - Use consistent build root variables It seems to me that %doc would be better with %doc docs/* http://people.redhat.com/lmacken/python-paste.spec http://people.redhat.com/lmacken/python-paste-0.9.3-3.src.rpm * Wed Jul 19 2006 Luke Macken <lmacken> - 0.9.3-3 - Fix doc inclusion I am not that comfortable with python packagin, but I have to start one day... As a first remark, the striping of shebangs with sed is not wrong, but prone to errors since even if the first lines of these files isn't a shebang anymore there won't be any error. * rpmlint output: E: python-paste zero-length /usr/lib/python2.4/site-packages/Paste-0.9.3-py2.4.egg-info/not-zip-safe I guess it is a usefull file? * package rightly named * open source licence, licence not included but not in the upstream package * spec legible * source match upstream c1b8f08d0a7e9ccb97e6ee524b26d39f Paste-0.9.3.tar.gz * BuildRequires are clean * Owns the paste directory it creates * %files section right, using a python scriplet * doc is small and don't affect runtime * no gui no lib APPROVED I modified the shebang removal expression to be a bit smarter :) %{__sed} -i -e '/^#!.*/,1 d' paste/util/scgiserver.py paste/debug/doctest_webapp.py Imported into CVS, added to owners list, FC5 branch requested, tagged and built for FC6. Thanks! |