Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 198613
Summary: | Review Request: compat-libgda - gnome database access library | ||||||
---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Denis Leroy <denis> | ||||
Component: | Package Review | Assignee: | Tom "spot" Callaway <tcallawa> | ||||
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> | ||||
Severity: | medium | Docs Contact: | |||||
Priority: | medium | ||||||
Version: | rawhide | ||||||
Target Milestone: | --- | ||||||
Target Release: | --- | ||||||
Hardware: | All | ||||||
OS: | Linux | ||||||
Whiteboard: | |||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | Environment: | ||||||
Last Closed: | 2006-09-11 19:01:25 UTC | Type: | --- | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Bug Depends On: | |||||||
Bug Blocks: | 163779, 199941, 199943, 201437 | ||||||
Attachments: |
|
Description
Denis Leroy
2006-07-12 10:37:56 UTC
Thanks Denis. As the maintainer of Glom, libgdamm, and pygda, and a contributor to libgda, I'd much prefer of course that Fedora just revert their libgda package back to the stable API. It seems silly to do all this work just to restore a stable API. Nobody should be using the unstable API. Fixed issue with compat-libgda configuration directory. Spec: http://www.poolshark.org/src/compat-libgda.spec SRPM: http://www.poolshark.org/src/compat-libgda-1.2.3-2.src.rpm OK, I went to review this one, and found a few really minor issues that I fixed. If you're ok with the minor changes, this package is approved. Specifically, I added an xbase conditional (since xbase is in FE), enabled everything that could be built by default in Fedora, and fixed the libraries so that they get handled properly by debuginfo. Also, I changed Source0 so it points to a URL. Last, I fixed the License tags for the provider packages so that they were GPL (only the core libgda libs are LGPL) and included the LGPL text in the main package as a %doc. REVIEW ======= - rpmlint checks return: W: compat-libgda-devel no-documentation W: compat-gda-mysql no-documentation W: compat-gda-odbc no-documentation W: compat-gda-postgres no-documentation W: compat-gda-sqlite no-documentation W: compat-gda-ldap no-documentation W: compat-gda-xbase no-documentation All ok. - package meets naming guidelines - package meets packaging guidelines - license (LGPL) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream - package compiles on devel (x86) - no missing BR - no unnecessary BR - locales grabbed with find_lang - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file - devel package ok - no .la files - post/postun ldconfig ok - devel requires base package n-v-r APPROVED (assuming you use my spec) Created attachment 136022 [details]
Updated compat-libgda spec file.
Thanks Tom, I'll use your spec file. Of course now that this package is approved, I'm willing to bet Gnome will release libgda 2.0 tomorrow :-) Built for RawHide. You should be able to rebuild libgdamm now. Please also build for FC-5. :) |