Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 198831 (varconf)
Summary: | Review Request: varconf - Configuration library used by WorldForge apps | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Wart <wart> |
Component: | Package Review | Assignee: | Christopher Stone <chris.stone> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | che666 |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2006-07-20 17:21:19 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779, 198839 |
Description
Wart
2006-07-13 22:48:02 UTC
- rpmlint output: W: varconf-devel no-documentation okay to ignore, I dont see any documentation which should go in devel - package named according to package naming guidelines - spec file name matches package %{name} - package meets packaging guidelines - license in spec file is compatible with open source license O package does not match actual upstream license - license file included in %doc - spec file written in American english - spec file is legible - sources match upstream b8f30226a1fee727fd124f716d8eb72e varconf-0.6.4.tar.gz - package successfully compiles and builds on x86_64 FC-5 - all build dependencies are in BuildRequires - package does not contain locales - package properly uses %post/%postun ldconfig - package is not relocatable - package owns all directories it creates - package does not contain duplicate files - file permissions are set properly - package contains proper %clean section - macro usage is consistant - package contains permissible content - package does not contain large documentation - files in %doc do not affect runtime - header files are in devel - pkgconfig files are in devel - libraries w/o suffix are in devel - devel package requires base package - package does not contain .la files - package is not a GUI needing .desktop files - package does not own files or directories owned by other packages ==== MUST ==== - devel package should have Requires: pkgconfig - make check should use smp flags - make check should be patched to work, (not ||:) all you need to do is add #include <assert.h> once conftest is created, you need to: cd tests ; ./conftest < conf.cfg - fix license to match actual upstream license (In reply to comment #1) > ==== MUST ==== > - devel package should have Requires: pkgconfig > - make check should use smp flags > - make check should be patched to work, (not ||:) all you need to do is add > #include <assert.h> > once conftest is created, you need to: cd tests ; ./conftest < conf.cfg > - fix license to match actual upstream license All fixed: http://www.kobold.org/~wart/fedora/varconf-0.6.4-2.src.rpm http://www.kobold.org/~wart/fedora/varconf.spec > once conftest is created, you need to: cd tests ; ./conftest < conf.cfg
^^ This should be added to %check section
(In reply to comment #3) > > once conftest is created, you need to: cd tests ; ./conftest < conf.cfg > > ^^ This should be added to %check section My bad. Here's the updated package: http://www.kobold.org/~wart/fedora/varconf.spec http://www.kobold.org/~wart/fedora/varconf-0.6.4-3.src.rpm Imported and built. Thanks! |