Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 198837 (eris)
| Summary: | Review Request: eris - Client-side session layer for Atlas-C++ | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Wart <wart> |
| Component: | Package Review | Assignee: | Christopher Stone <chris.stone> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | che666 |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2006-07-27 18:49:22 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 198829, 198832, 198835 | ||
| Bug Blocks: | 163779, 198839 | ||
|
Description
Wart
2006-07-13 22:58:57 UTC
- rpmlint output:
W: eris incoherent-version-in-changelog 1.3.11-0.1 1.3.11-1.fc5
Must fix changelog version number
- package name meets package naming guidelines
- spec file name matches package %{name}
- package meets packaging guidelines
- package is licensed with open source compatible license
- license matches actual upstream license
- license file included in %doc
- spec file written in American english
- spec file is legible
- source file matches upstream
632bb5ad0e8cbcf59c8f26c50c320b7d eris-1.3.11.tar.gz
- package successfully compiles and builds on x86_64 FC-5
O package does not list all build dependencies, configure checks for glib-2.0
which is not provided
- package does not contain locales
- package contains proper %post/%postun ldconfig calls
- package is not relocatable
- package owns all directories it creates
- package does not contain duplicate files
- file permissions are set properly
- package contains proper %clean section
- macro usage is consistent
- package contains permissible content
- package does not contain large documentation
- files in %doc do not affect runtime
- header files are in devel package
- pkgconfig files are in devel
- libraries w/o suffix are in devel
- devel package requires base package
- package does not contain any .la files
- package is not a GUI needing a .desktop file
- package does not own files or directories owned by other packages
==== MUST ====
- Remove pkgconfig from BuildRequries, this should be picked up by the devel
packages
- Fix changelog version number
- "outpu" in description should be "output"
- Why is glib-2.0 not added in BuildRequires?
- Add a %check section
- %doc in devel should be docs/html/*
(In reply to comment #1) > ==== MUST ==== > - Remove pkgconfig from BuildRequries, this should be picked up by the devel > packages > - Fix changelog version number > - "outpu" in description should be "output" fixed, fixed, and fixed. > - Why is glib-2.0 not added in BuildRequires? I didn't see that it made any difference during the build, but I guess upstream has it there for a reason. Added. > - Add a %check section Added. The first time I ran this on FC4-x86_64 in mock, the tests hung. The next few times it was ok. I'll keep an eye on the build system and disable the tests if they cause problems. > - %doc in devel should be docs/html/* Fixed. http://www.kobold.org/~wart/fedora/eris-1.3.11-2.src.rpm http://www.kobold.org/~wart/fedora/eris.spec Thanks for the review! This has been imported, but can't be built until wfmath is approved. This has been built now that wfmath is available. Thanks! |