Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 199573
Summary: | Review Request: BackupPC - high-performance backup system | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Mike McGrath <imlinux> |
Component: | Package Review | Assignee: | Dennis Gilmore <dennis> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | a.badger, bjohnson, dennis, fedora, pahan |
Target Milestone: | --- | Flags: | gwync:
fedora-cvs+
|
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2006-08-10 01:53:11 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 199647 | ||
Bug Blocks: | 163779 |
Description
Mike McGrath
2006-07-20 15:07:54 UTC
SPEC: http://mmcgrath.net/~mmcgrath/BackupPC/BackupPC.spec SRPM: http://mmcgrath.net/~mmcgrath/BackupPC/BackupPC-2.1.2-1.src.rpm * Fri Jul 21 2006 Mike McGrath <imlinux> 2.1.2-2 - Added requires: perl(File::RsyncP) ok couple of quick things builds ok in mock looking through build log we probably want to default the backup server to localhost not the builders name in the config, and i think we should change in the config the default backup type from smb to rsync package meets naming and packaging guidelines. specfile is properly named, is cleanly written and uses macros consistently. build root is correct. %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) license field matches the actual license. license is open source-compatible. GPL License text included in package. source files match upstream: [dennis@daedalus SPECS]$ sha1sum BackupPC-2.1.2.tar.gz 9f99e201fbf6bbd016c19007e5fb4072d77312c7 BackupPC-2.1.2.tar.gz [dennis@daedalus SPECS]$ sha1sum ../SOURCES/BackupPC-2.1.2.tar.gz 9f99e201fbf6bbd016c19007e5fb4072d77312c7 ../SOURCES/BackupPC-2.1.2.tar.gz latest version is being packaged. BuildRequires are proper. package builds in mock ( ). rpmlint [dennis@daedalus SPECS]$ rpmlint /var/lib/mock/aurora-2-sparc-extras/result/BackupPC-2.1.2-2.noarch.rpm E: BackupPC non-executable-script /usr/share/BackupPC/lib/BackupPC/Lang/nl.pm 0444 E: BackupPC non-standard-uid /var/lib/BackupPC/cpool backuppc E: BackupPC non-standard-dir-perm /var/lib/BackupPC/cpool 0750 E: BackupPC non-standard-uid /etc/BackupPC backuppc E: BackupPC non-standard-gid /etc/BackupPC backuppc E: BackupPC non-standard-dir-perm /etc/BackupPC 0750 E: BackupPC non-standard-uid /var/lib/BackupPC/pc backuppc E: BackupPC non-standard-dir-perm /var/lib/BackupPC/pc 0750 E: BackupPC non-standard-uid /etc/BackupPC/hosts backuppc E: BackupPC non-standard-gid /etc/BackupPC/hosts backuppc E: BackupPC non-standard-uid /usr/share/BackupPC/sbin/BackupPC_Admin backuppc E: BackupPC non-standard-gid /usr/share/BackupPC/sbin/BackupPC_Admin apache E: BackupPC setuid-binary /usr/share/BackupPC/sbin/BackupPC_Admin backuppc 04750 E: BackupPC non-standard-executable-perm /usr/share/BackupPC/sbin/BackupPC_Admin 04750 E: BackupPC non-standard-uid /var/lib/BackupPC/conf backuppc W: BackupPC dangling-symlink /var/lib/BackupPC/conf /etc/BackupPC/ E: BackupPC non-executable-script /usr/share/BackupPC/lib/BackupPC/Lang/es.pm 0444 E: BackupPC non-standard-uid /etc/BackupPC/config.pl backuppc E: BackupPC non-standard-gid /etc/BackupPC/config.pl backuppc E: BackupPC non-readable /etc/BackupPC/config.pl 0640 E: BackupPC non-executable-script /usr/share/BackupPC/lib/BackupPC/Lang/it.pm 0444 E: BackupPC non-executable-script /usr/share/BackupPC/lib/BackupPC/Lang/de.pm 0444 E: BackupPC non-standard-uid /var/lib/BackupPC/pool backuppc E: BackupPC non-standard-dir-perm /var/lib/BackupPC/pool 0750 E: BackupPC non-executable-script /usr/share/BackupPC/lib/BackupPC/Lang/en.pm 0444 E: BackupPC non-standard-uid /var/lib/BackupPC/log backuppc E: BackupPC non-standard-uid /var/lib/BackupPC/trash backuppc E: BackupPC non-standard-dir-perm /var/lib/BackupPC/trash 0750 E: BackupPC non-standard-uid /var/log/BackupPC backuppc E: BackupPC non-standard-gid /var/log/BackupPC backuppc E: BackupPC non-standard-uid /var/lib/BackupPC backuppc E: BackupPC non-standard-dir-perm /var/lib/BackupPC 0750 E: BackupPC non-executable-script /usr/share/BackupPC/lib/BackupPC/Lang/fr.pm 0444 E: BackupPC incoherent-subsys /etc/rc.d/init.d/BackupPC backuppc W: BackupPC incoherent-init-script-name BackupPC final provides and requires are sane: [dennis@daedalus SPECS]$ rpm -q --requires BackupPC /bin/sh /bin/sh /bin/sh /bin/sh /bin/sh /sbin/chkconfig /sbin/chkconfig /sbin/service /sbin/service /sbin/service /usr/bin/perl /usr/sbin/useradd /usr/sbin/usermod config(BackupPC) = 2.1.2-2 httpd perl(Archive::Zip) perl(BackupPC::Attrib) perl(BackupPC::CGI::Lib) perl(BackupPC::FileZIO) perl(BackupPC::Lib) perl(BackupPC::PoolWrite) perl(BackupPC::View) perl(BackupPC::Xfer::Archive) perl(BackupPC::Xfer::Rsync) perl(BackupPC::Xfer::RsyncDigest) perl(BackupPC::Xfer::RsyncFileIO) perl(BackupPC::Xfer::Smb) perl(BackupPC::Xfer::Tar) perl(BackupPC::Zip::FileMember) perl(CGI) perl(CGI::Carp) perl(Carp) perl(Compress::Zlib) perl(Config) perl(Cwd) perl(Data::Dumper) perl(Digest::MD5) perl(DirHandle) perl(Exporter) perl(Fcntl) perl(File::Compare) perl(File::Copy) perl(File::Find) perl(File::Path) perl(File::RsyncP) perl(Getopt::Std) perl(IO::Handle) perl(POSIX) perl(Socket) perl(constant) perl(lib) perl(strict) perl(vars) perl-suidperl [dennis@daedalus SPECS]$ rpm -q --provides BackupPC config(BackupPC) = 2.1.2-2 perl(BackupPC::Attrib) perl(BackupPC::CGI::AdminOptions) perl(BackupPC::CGI::Archive) perl(BackupPC::CGI::ArchiveInfo) perl(BackupPC::CGI::Browse) perl(BackupPC::CGI::DirHistory) perl(BackupPC::CGI::EmailSummary) perl(BackupPC::CGI::GeneralInfo) perl(BackupPC::CGI::HostInfo) perl(BackupPC::CGI::LOGlist) perl(BackupPC::CGI::Lib) perl(BackupPC::CGI::Queue) perl(BackupPC::CGI::ReloadServer) perl(BackupPC::CGI::Restore) perl(BackupPC::CGI::RestoreFile) perl(BackupPC::CGI::RestoreInfo) perl(BackupPC::CGI::StartServer) perl(BackupPC::CGI::StartStopBackup) perl(BackupPC::CGI::StopServer) perl(BackupPC::CGI::Summary) perl(BackupPC::CGI::View) perl(BackupPC::FileZIO) perl(BackupPC::Lib) perl(BackupPC::PoolWrite) perl(BackupPC::View) perl(BackupPC::Xfer::Archive) perl(BackupPC::Xfer::Rsync) perl(BackupPC::Xfer::RsyncDigest) perl(BackupPC::Xfer::RsyncFileIO) perl(BackupPC::Xfer::Smb) perl(BackupPC::Xfer::Tar) perl(BackupPC::Zip::FileMember) BackupPC = 2.1.2-2 no shared libraries are present. package is not relocatable. owns the directories it creates. doesn't own any directories it shouldn't. no duplicates in %files. file permissions are appropriate. %clean is present. scriptlets present and correct code, not content. documentation is small, so no -docs subpackage is necessary. %docs are not necessary for the proper functioning of the package. no headers. no pkgconfig files. no libtool .la droppings. not a GUI app. Non Fatal errors dist tag is not present. as for the rpmlint warnings errors i think that due to the nature of this app they are needed to be as they are. It provides a layer of seperation from the backup app and the system. Spec: http://mmcgrath.net/~mmcgrath/BackupPC/BackupPC.spec SRPM: http://mmcgrath.net/~mmcgrath/BackupPC/BackupPC-2.1.2-3.src.rpm - Changes to defaults in config.pl - Added Requires: rsync Spec: http://mmcgrath.net/~mmcgrath/BackupPC/BackupPC.spec SRPM: http://mmcgrath.net/~mmcgrath/BackupPC/BackupPC-2.1.2-3.src.rpm - Properly marking config files as such FWIW, a few comments: - The latest spec is for Release 4. The download area seems to contain a binary rpm for this release, but not a src rpm. - In order to set up ssh keys, the admin must (I think) change the backuppc user to have a shell, set up ssh, and then change back to /sbin/nologin. Not sure if there's a way around this, but you might want to document this. - You might want to include upstream patch BackupPC-2.1.2pl2.diff (which is needed to work with the latest versions of rsync). It also fixes other bugs. - perl-File-RsyncP-0.62-1.src.rpm wouldn't compile for me on an up-to-date x86_64 FC5. 0.52 is OK. HTH Spec: http://mmcgrath.net/~mmcgrath/BackupPC/BackupPC.spec SRPM: http://mmcgrath.net/~mmcgrath/BackupPC/BackupPC-2.1.2-4.src.rpm - Added upstream patch try using http://mmcgrath.net/~mmcgrath/perl-File-RsyncP/perl-File-RsyncP-0.62-2.src.rpm Its actually been approved and built. You should be able to yum it soon. SSH keys - I find it best not to tell admins how their security should be done. Especially since BackupPC supports so many different methods for backup. Having said that it might not be a bad idea to at least point them to the BackupPC documentation for setting up ssh keys. (In reply to comment #7) > Spec: http://mmcgrath.net/~mmcgrath/BackupPC/BackupPC.spec > SRPM: http://mmcgrath.net/~mmcgrath/BackupPC/BackupPC-2.1.2-4.src.rpm Do you mean 2.1.2-5? > > - Added upstream patch Thanks :) > > try using > http://mmcgrath.net/~mmcgrath/perl-File-RsyncP/perl-File-RsyncP-0.62-2.src.rpm > Its actually been approved and built. You should be able to yum it soon. Builds for me :) > > SSH keys - I find it best not to tell admins how their security should be done. > Especially since BackupPC supports so many different methods for backup. > Having said that it might not be a bad idea to at least point them to the > BackupPC documentation for setting up ssh keys. Agreed. I guess my point is: - The package defaults to rsync over ssh. - The official BackupPC docs describe a procedure for setting up ssh that won't work if the backuppc user does not have a shell. Again, not really sure if you should do anything about this... Hopefully most users will figure it out. Spec: http://mmcgrath.net/~mmcgrath/BackupPC/BackupPC.spec SRPM: http://mmcgrath.net/~mmcgrath/BackupPC/BackupPC-2.1.2-6.src.rpm - One more config change looks good now APPROVED Built.... A long time ago. Please leave the FE-ACCEPT blocker... Package Change Request ====================== Package Name: BackupPC New Branches: EL-4 EL-5 cvs done. Package Change Request ====================== Package Name: BackupPC New Branches: epel7 Owners: bjohnson Git done (by process-git-requests). |