Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 200422
| Summary: | Review Request: international-time (first package, seeking sponsor) | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Tim Waugh <twaugh> | ||||
| Component: | Package Review | Assignee: | Kevin Fenzi <kevin> | ||||
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | panemade | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2006-10-27 09:10:43 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 163779 | ||||||
| Attachments: |
|
||||||
|
Description
Tim Waugh
2006-07-27 16:20:51 UTC
Hi Tim,
A couple of comments:
* The preferred value for the BuildRoot tag is
"%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)". This is not a
requirement for approval, though.
* desktop-file-install is usually (always?) called using "--vendor fedora" and
"--add-category X-Fedora".
* rpmlint has a few complaints (none of them serious):
W: international-time summary-ended-with-dot
W: international-time no-url-tag
W: international-time no-documentation
* You can drop the 'pygtk2' requirement since 'pygtk2-libglade' already depends
on it. Also, it seems rpm already adds a dependency on "/usr/bin/python"
automatically so the 'python' requirement might be redundant... but I'm not
really sure.
I did some changes to this package's SPEC file. But as Author has not given URL from where a source tarball can be downloaded and not included License copy in %doc, rpmlint is not silent with warnings W: international-time no-url-tag W: international-time no-documentation Created attachment 133473 [details]
Clean SPEC file
I have fixed buildroot, BR, %prep section, added dist tag, fixed desktop file
installation, added %doc
Jeez, this has sat around for a long time. Tim, I know your folks are rather busy lately, but do you still want to pursue getting this into extras? I do -- I'll have some time for this once FC6 is out, and will finish the process. Sorry for the delay. Tim,
You can use SPEC file I attached in comment #3.
Thanks, updated. Spec URL: http://cyberelk.net/tim/data/international-time/international-time.spec SRPM URL: http://cyberelk.net/tim/data/international-time/international-time-0.0.1-2.src.rpm Hey Tim. Here's a review... OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. See below - License See below - License field in spec matches See below - License file included in package OK - Spec in American English OK - Spec is legible. See below - Sources match upstream md5sum: OK - BuildRequires correct See below - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Package is a GUI app and has a .desktop file OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. See below - No rpmlint output. OK - final provides and requires are sane: SHOULD Items: OK - Should build in mock. i386/x86_64 ok - Should build on all supported archs OK - Should function as described. OK - Should have dist tag See below - Should package latest version Issues: 1. Is there an upstream Source0 URL where this is available? Are you the upstream author? 2. Can you include some kind of license information or files? If it's GPL, might include a COPYING file and perhaps note that it's distributed under the GPL in a README or in the source files? 3. You might change the default perms from: %defattr(-,root,root) to %defattr(-,root,root,-) 4. rpmlint says: W: international-time no-url-tag W: international-time no-documentation 5. It seems to run fine here, but I get the following warning: (international-time:4464): libglade-WARNING **: could not find glade file 'international-time.glade' 1. I am the upstream author. I've put the original tarball in the cyberelk.net directory now. 2. COPYING now included. 3. Changed, thanks. 4. URL tag added. There just isn't any documentation; I haven't written any. There's not a lot to say. :-) 5. Warning removed. Spec URL: http://cyberelk.net/tim/data/international-time/international-time.spec SRPM URL: http://cyberelk.net/tim/data/international-time/international-time-0.0.2-1.src.rpm 1. ok. 2. I see the COPYING file in the new upstream release, but not in the spec. 3. ok. 4. ok. Fair enough. It is a pretty simple app. 5. ok. If you could add %doc COPYING to the spec when you check it in, that would be great. I don't see any more blockers, so this package is APPROVED, and I would be happy to sponsor you. Please continue the process from here: http://fedoraproject.org/wiki/Extras/Contributors#head- bb3314e7b80fd98f037edd46f6d1efafbb611752 Don't forget to close this review request with NEXTRELEASE once it's been imported and built. |