Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 200438
Summary: | Review Request: tango-icon-theme - Icons from Tango Project | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Piotr Drąg <piotrdrag> |
Component: | Package Review | Assignee: | Brian Pepple <bdpepple> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | gnomeuser, lmacken, tjb |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2006-09-12 18:47:55 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779 |
Description
Piotr Drąg
2006-07-27 17:32:21 UTC
I can't sponsor you, but I'll give you something very review-like: 1. includes BuildRequires: icon-naming-utils >= 0.7.2 but that isn't in Core or Extras (yet). 2. scriptlets should be: %post touch --no-create %{_datadir}/icons/Tango 2> /dev/null ||: gtk-update-icon-cache -q %{_datadir}/icons/Tango 2> /dev/null ||: %postun touch --no-create %{_datadir}/icons/Tango 2> /dev/null ||: gtk-update-icon-cache -q %{_datadir}/icons/Tango 2> /dev/null ||: 3. Per http://tango.freedesktop.org/Frequently_Asked_Questions use License: Creative Commons Attribution Share-Alike Re: icon-naming-utils It would probably be best if the same person maintained both icon-naming-utils and tango-icon-theme. You can use what I've got for a starting point there (if you don't have it already): http://kde-redhat.unl.edu/apt/kde-redhat/SPECS/icon-naming-utils.spec (and for reference and pointers http://kde-redhat.unl.edu/apt/kde-redhat/SPECS/tango-icon-theme.spec ) icon-naming-utils is in core and rawhide sports version 0.7.3 http://cvs.fedora.redhat.com/viewcvs/devel/icon-naming-utils/ Comment #1: Thanks for the scriptlets. #2: [raven@host-86-63-147-192 SRPMS]$ rpmlint tango-icon-theme-0.7.2-1.src.rpm W: tango-icon-theme invalid-license Creative Commons Attribution Share-AlikeCan #3: Can someone add it to FC5 updates-released (or testing)? > icon-naming-utils is in core and rawhide sports version 0.7.3 Coolness, how did I miss that? (: >[raven@host-86-63-147-192 SRPMS]$ rpmlint tango-icon-theme-0.7.2-1.src.rpm >W: tango-icon-theme invalid-license Creative Commons Attribution Share-AlikeCan Regardless, that *is* the license (and it is valid, regardless of rpmlint's whininess) >#3: Can someone add it to FC5 updates-released (or testing)? To what are you referring when you say "it"? >Regardless, that *is* the license (and it is valid, regardless of rpmlint's whininess) OK, you are right. >To what are you referring when you say "it"? icon-naming-utils, of course. Sorry for my poor English... New spec and SRPM: http://pmail.pl/~raven/tango-icon-theme.spec http://pmail.pl/~raven/tango-icon-theme-0.7.2-2.src.rpm >>To what are you referring when you say "it"? > icon-naming-utils, of course. Sorry for my poor English... Very little chance, new packages aren't (usually) added to the distro after it's been released. That doesn't preclude it's appearance in fc5/Extras. Back to the package, would you consider building with ./configure --enable-png-creation (it helps out kde users) >Very little chance, new packages aren't (usually) added to the distro after it's been released. That doesn't preclude it's appearance in fc5/Extras. Sorry for my English again. When I said "add to updates", I meant "update to 0.7.3", because this package is in FC5, but in old version (0.6.7). >Back to the package, would you consider building with >./configure --enable-png-creation >(it helps out kde users) No problem. > I meant "update to 0.7.3", because this package is in FC5,
> but in old version (0.6.7).
Open a bugzilla report, and request and update (and tell them why, you need it
for tango-icon-theme on fc5/Extras)
Isn't the tango icons already in Rawhide? Why else would the icon-naming-utils be in Core? afaict, tango is not is rawhide. Dunno why icon-naming-utils is in Core, but it's been there since FC-5 >Open a bugzilla report, and request and update (and tell them why, you need it for tango-icon-theme on fc5/Extras) Thanks for all your help. :) (bug 200457) >Back to the package, would you consider building with >./configure --enable-png-creation >(it helps out kde users) Done, new spec and SRPM: http://pmail.pl/~raven/tango-icon-theme.spec http://pmail.pl/~raven/tango-icon-theme-0.7.2-3.src.rpm You should be able to drop the BR on ImageMagick & librsvg2, since the respective devel packages sonames should pull these in. Thanks, new spec and SRPM: http://pmail.pl/~raven/tango-icon-theme.spec http://pmail.pl/~raven/tango-icon-theme-0.7.2-4.src.rpm (In reply to comment #11) > Isn't the tango icons already in Rawhide? Why else would the icon-naming-utils > be in Core? http://fedoraproject.org/wiki/Artwork/BluecurveAndBeyond/Gallery The new theme has adopted the specification, naming etc from Tango for consistency. This bombs out on Development (x86_64) (cd /var/tmp/tango-icon-theme-0.7.2-4-root-root/usr/share/icons/Tango && \ for icon in address-book-new.png appointment-new.png bookmark-new.png contact-new.png document-new.png document-open.png document-print.png document-print-preview.png document-properties.png document-save.png document-save-as.png edit-clear.png edit-copy.png edit-cut.png edit-delete.png edit-find.png edit-find-replace.png edit-paste.png edit-redo.png edit-select-all.png edit-undo.png folder-new.png format-indent-less.png format-indent-more.png format-justify-center.png format-justify-fill.png format-justify-left.png format-justify-right.png format-text-bold.png format-text-italic.png format-text-strikethrough.png format-text-underline.png go-bottom.png go-down.png go-first.png go-home.png go-jump.png go-last.png go-next.png go-previous.png go-top.png go-up.png list-add.png list-remove.png mail-forward.png mail-message-new.png mail-mark-junk.png mail-mark-not-junk.png mail-reply-all.png mail-reply-sender.png mail-send-receive.png media-eject.png media-playback-pause.png media-playback-start.png media-playback-stop.png media-record.png media-seek-backward.png media-seek-forward.png media-skip-backward.png media-skip-forward.png process-stop.png system-lock-screen.png system-log-out.png system-search.png system-shutdown.png tab-new.png view-fullscreen.png view-refresh.png window-new.png ; do \ /usr/bin/convert -bordercolor Transparent -border 1x1 22x22/actions/$icon 24x24/actions/$icon; \ done) /usr/bin/convert: symbol lookup error: /usr/lib64/ImageMagick-6.2.8/modules-Q16/coders/png.so: undefined symbol: png_get_asm_flags /usr/bin/convert: symbol lookup error: /usr/lib64/ImageMagick-6.2.8/modules-Q16/coders/png.so: undefined symbol: png_get_asm_flags /usr/bin/convert: symbol lookup error: /usr/lib64/ImageMagick-6.2.8/modules-Q16/coders/png.so: undefined symbol: png_get_asm_flags /usr/bin/convert: symbol lookup error: /usr/lib64/ImageMagick-6.2.8/modules-Q16/coders/png.so: undefined symbol: png_get_asm_flags /usr/bin/convert: symbol lookup error: /usr/lib64/ImageMagick-6.2.8/modules-Q16/coders/png.so: undefined symbol: png_get_asm_flags /usr/bin/convert: symbol lookup error: /usr/lib64/ImageMagick-6.2.8/modules-Q16/coders/png.so: undefined symbol: png_get_asm_flags /usr/bin/convert: symbol lookup error: /usr/lib64/ImageMagick-6.2.8/modules-Q16/coders/png.so: undefined symbol: png_get_asm_flags /usr/bin/convert: symbol lookup error: /usr/lib64/ImageMagick-6.2.8/modules-Q16/coders/png.so: undefined symbol: png_get_asm_flags /usr/bin/convert: symbol lookup error: /usr/lib64/ImageMagick-6.2.8/modules-Q16/coders/png.so: undefined symbol: png_get_asm_flags /usr/bin/convert: symbol lookup error: /usr/lib64/ImageMagick-6.2.8/modules-Q16/coders/png.so: undefined symbol: png_get_asm_flags /usr/bin/convert: symbol lookup error: /usr/lib64/ImageMagick-6.2.8/modules-Q16/coders/png.so: undefined symbol: png_get_asm_flags /usr/bin/convert: symbol lookup error: /usr/lib64/ImageMagick-6.2.8/modules-Q16/coders/png.so: undefined symbol: png_get_asm_flags /usr/bin/convert: symbol lookup error: /usr/lib64/ImageMagick-6.2.8/modules-Q16/coders/png.so: undefined symbol: png_get_asm_flags /usr/bin/convert: symbol lookup error: /usr/lib64/ImageMagick-6.2.8/modules-Q16/coders/png.so: undefined symbol: png_get_asm_flags /usr/bin/convert: symbol lookup error: /usr/lib64/ImageMagick-6.2.8/modules-Q16/coders/png.so: undefined symbol: png_get_asm_flags /usr/bin/convert: symbol lookup error: /usr/lib64/ImageMagick-6.2.8/modules-Q16/coders/png.so: undefined symbol: png_get_asm_flags /usr/bin/convert: symbol lookup error: /usr/lib64/ImageMagick-6.2.8/modules-Q16/coders/png.so: undefined symbol: png_get_asm_flags /usr/bin/convert: symbol lookup error: /usr/lib64/ImageMagick-6.2.8/modules-Q16/coders/png.so: undefined symbol: png_get_asm_flags /usr/bin/convert: symbol lookup error: /usr/lib64/ImageMagick-6.2.8/modules-Q16/coders/png.so: undefined symbol: png_get_asm_flags /usr/bin/convert: symbol lookup error: /usr/lib64/ImageMagick-6.2.8/modules-Q16/coders/png.so: undefined symbol: png_get_asm_flags /usr/bin/convert: symbol lookup error: /usr/lib64/ImageMagick-6.2.8/modules-Q16/coders/png.so: undefined symbol: png_get_asm_flags /usr/bin/convert: symbol lookup error: /usr/lib64/ImageMagick-6.2.8/modules-Q16/coders/png.so: undefined symbol: png_get_asm_flags /usr/bin/convert: symbol lookup error: /usr/lib64/ImageMagick-6.2.8/modules-Q16/coders/png.so: undefined symbol: png_get_asm_flags /usr/bin/convert: symbol lookup error: /usr/lib64/ImageMagick-6.2.8/modules-Q16/coders/png.so: undefined symbol: png_get_asm_flags /usr/bin/convert: symbol lookup error: /usr/lib64/ImageMagick-6.2.8/modules-Q16/coders/png.so: undefined symbol: png_get_asm_flags /usr/bin/convert: symbol lookup error: /usr/lib64/ImageMagick-6.2.8/modules-Q16/coders/png.so: undefined symbol: png_get_asm_flags /usr/bin/convert: symbol lookup error: /usr/lib64/ImageMagick-6.2.8/modules-Q16/coders/png.so: undefined symbol: png_get_asm_flags /usr/bin/convert: symbol lookup error: /usr/lib64/ImageMagick-6.2.8/modules-Q16/coders/png.so: undefined symbol: png_get_asm_flags /usr/bin/convert: symbol lookup error: /usr/lib64/ImageMagick-6.2.8/modules-Q16/coders/png.so: undefined symbol: png_get_asm_flags /usr/bin/convert: symbol lookup error: /usr/lib64/ImageMagick-6.2.8/modules-Q16/coders/png.so: undefined symbol: png_get_asm_flags /usr/bin/convert: symbol lookup error: /usr/lib64/ImageMagick-6.2.8/modules-Q16/coders/png.so: undefined symbol: png_get_asm_flags /usr/bin/convert: symbol lookup error: /usr/lib64/ImageMagick-6.2.8/modules-Q16/coders/png.so: undefined symbol: png_get_asm_flags /usr/bin/convert: symbol lookup error: /usr/lib64/ImageMagick-6.2.8/modules-Q16/coders/png.so: undefined symbol: png_get_asm_flags /usr/bin/convert: symbol lookup error: /usr/lib64/ImageMagick-6.2.8/modules-Q16/coders/png.so: undefined symbol: png_get_asm_flags /usr/bin/convert: symbol lookup error: /usr/lib64/ImageMagick-6.2.8/modules-Q16/coders/png.so: undefined symbol: png_get_asm_flags /usr/bin/convert: symbol lookup error: /usr/lib64/ImageMagick-6.2.8/modules-Q16/coders/png.so: undefined symbol: png_get_asm_flags /usr/bin/convert: symbol lookup error: /usr/lib64/ImageMagick-6.2.8/modules-Q16/coders/png.so: undefined symbol: png_get_asm_flags /usr/bin/convert: symbol lookup error: /usr/lib64/ImageMagick-6.2.8/modules-Q16/coders/png.so: undefined symbol: png_get_asm_flags /usr/bin/convert: symbol lookup error: /usr/lib64/ImageMagick-6.2.8/modules-Q16/coders/png.so: undefined symbol: png_get_asm_flags /usr/bin/convert: symbol lookup error: /usr/lib64/ImageMagick-6.2.8/modules-Q16/coders/png.so: undefined symbol: png_get_asm_flags /usr/bin/convert: symbol lookup error: /usr/lib64/ImageMagick-6.2.8/modules-Q16/coders/png.so: undefined symbol: png_get_asm_flags /usr/bin/convert: symbol lookup error: /usr/lib64/ImageMagick-6.2.8/modules-Q16/coders/png.so: undefined symbol: png_get_asm_flags /usr/bin/convert: symbol lookup error: /usr/lib64/ImageMagick-6.2.8/modules-Q16/coders/png.so: undefined symbol: png_get_asm_flags /usr/bin/convert: symbol lookup error: /usr/lib64/ImageMagick-6.2.8/modules-Q16/coders/png.so: undefined symbol: png_get_asm_flags /usr/bin/convert: symbol lookup error: /usr/lib64/ImageMagick-6.2.8/modules-Q16/coders/png.so: undefined symbol: png_get_asm_flags /usr/bin/convert: symbol lookup error: /usr/lib64/ImageMagick-6.2.8/modules-Q16/coders/png.so: undefined symbol: png_get_asm_flags /usr/bin/convert: symbol lookup error: /usr/lib64/ImageMagick-6.2.8/modules-Q16/coders/png.so: undefined symbol: png_get_asm_flags /usr/bin/convert: symbol lookup error: /usr/lib64/ImageMagick-6.2.8/modules-Q16/coders/png.so: undefined symbol: png_get_asm_flags /usr/bin/convert: symbol lookup error: /usr/lib64/ImageMagick-6.2.8/modules-Q16/coders/png.so: undefined symbol: png_get_asm_flags /usr/bin/convert: symbol lookup error: /usr/lib64/ImageMagick-6.2.8/modules-Q16/coders/png.so: undefined symbol: png_get_asm_flags /usr/bin/convert: symbol lookup error: /usr/lib64/ImageMagick-6.2.8/modules-Q16/coders/png.so: undefined symbol: png_get_asm_flags /usr/bin/convert: symbol lookup error: /usr/lib64/ImageMagick-6.2.8/modules-Q16/coders/png.so: undefined symbol: png_get_asm_flags /usr/bin/convert: symbol lookup error: /usr/lib64/ImageMagick-6.2.8/modules-Q16/coders/png.so: undefined symbol: png_get_asm_flags /usr/bin/convert: symbol lookup error: /usr/lib64/ImageMagick-6.2.8/modules-Q16/coders/png.so: undefined symbol: png_get_asm_flags /usr/bin/convert: symbol lookup error: /usr/lib64/ImageMagick-6.2.8/modules-Q16/coders/png.so: undefined symbol: png_get_asm_flags /usr/bin/convert: symbol lookup error: /usr/lib64/ImageMagick-6.2.8/modules-Q16/coders/png.so: undefined symbol: png_get_asm_flags /usr/bin/convert: symbol lookup error: /usr/lib64/ImageMagick-6.2.8/modules-Q16/coders/png.so: undefined symbol: png_get_asm_flags /usr/bin/convert: symbol lookup error: /usr/lib64/ImageMagick-6.2.8/modules-Q16/coders/png.so: undefined symbol: png_get_asm_flags /usr/bin/convert: symbol lookup error: /usr/lib64/ImageMagick-6.2.8/modules-Q16/coders/png.so: undefined symbol: png_get_asm_flags /usr/bin/convert: symbol lookup error: /usr/lib64/ImageMagick-6.2.8/modules-Q16/coders/png.so: undefined symbol: png_get_asm_flags /usr/bin/convert: symbol lookup error: /usr/lib64/ImageMagick-6.2.8/modules-Q16/coders/png.so: undefined symbol: png_get_asm_flags /usr/bin/convert: symbol lookup error: /usr/lib64/ImageMagick-6.2.8/modules-Q16/coders/png.so: undefined symbol: png_get_asm_flags /usr/bin/convert: symbol lookup error: /usr/lib64/ImageMagick-6.2.8/modules-Q16/coders/png.so: undefined symbol: png_get_asm_flags /usr/bin/convert: symbol lookup error: /usr/lib64/ImageMagick-6.2.8/modules-Q16/coders/png.so: undefined symbol: png_get_asm_flags /usr/bin/convert: symbol lookup error: /usr/lib64/ImageMagick-6.2.8/modules-Q16/coders/png.so: undefined symbol: png_get_asm_flags /usr/bin/convert: symbol lookup error: /usr/lib64/ImageMagick-6.2.8/modules-Q16/coders/png.so: undefined symbol: png_get_asm_flags /usr/bin/convert: symbol lookup error: /usr/lib64/ImageMagick-6.2.8/modules-Q16/coders/png.so: undefined symbol: png_get_asm_flags /usr/bin/convert: symbol lookup error: /usr/lib64/ImageMagick-6.2.8/modules-Q16/coders/png.so: undefined symbol: png_get_asm_flags /usr/bin/convert: symbol lookup error: /usr/lib64/ImageMagick-6.2.8/modules-Q16/coders/png.so: undefined symbol: png_get_asm_flags make[3]: *** [install-data-local] Fejl 127 make[3]: Forlader katalog '/usr/src/redhat/BUILD/tango-icon-theme-0.7.2/22x22/actions' make[2]: *** [install-am] Fejl 2 make[2]: Forlader katalog '/usr/src/redhat/BUILD/tango-icon-theme-0.7.2/22x22/actions' make[1]: *** [install-recursive] Fejl 1 make[1]: Forlader katalog '/usr/src/redhat/BUILD/tango-icon-theme-0.7.2/22x22' make: *** [install-recursive] Fejl 1 fejl: Fejl-afslutningsstatus fra /var/tmp/rpm-tmp.11591 (%install) /usr/bin/convert: symbol lookup error: /usr/lib64/ImageMagick-6.2.8/modules-Q16/coders/png.so: undefined symbol: This is an ImageMagick bug and needs reporting in bugzilla. It isn't anything to do with the package (by the looks of it) Turns out to be a libpng bug, it's already fixed: https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196580 ImageMagick-6.2.8.0-2.x86_64 still has this bug. While the libpng bug has been fixed in libpng-1.2.10-6, IM needs to be rebuilt against it. I did, and it worked fine. Since this isn't blocked by the ImageMagick/libpng screwiness anymore is there an eta on approval. I'd love to see Tango goodness on my desktop without hand compiling it. The main holdup is that Piotr FE_NEEDSPONSOR. MD5Sums: eace48f8340a95d7134632bad6287100 tango-icon-theme-0.7.2.tar.gz Good: * Source URL is canonical * Upstream source tarball verified * Package name conforms to the Fedora Naming Guideline * Group Tag is from the official list * Buildroot has all required elements * All paths begin with macros * All directories are owned by this or other packages * All necessary BuildRequires listed. * All desired features are enabled * Builds fine in mock. * rpmlint gives the following error that can be ignored: W: tango-icon-theme invalid-license Creative Commons Attribution Share-Alike Minor: * Unnecessary BR: automake isn't needed. This needs to be fixed before importing into CVS. +1 APPROVED, and I'll be your sponsor. http://fedoraproject.org/wiki/Extras/Contributors#head-a89c07b5b8abe7748b6b39f0f89768d595234907 FC-5 and devel created and built successfully, closing as NEXTRELEASE. |