Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 200472

Summary:	Review Request: perl-POE-Component-SNMP
Product:	[Fedora] Fedora	Reporter:	Chris Weyl <cweyl>
Component:	Package Review	Assignee:	Jason Tibbitts <j>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Package Reviews List <fedora-package-review>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2006-07-28 04:12:17 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	163779

Description Chris Weyl 2006-07-27 22:38:37 UTC

Spec URL: http://home.comcast.net/~ckweyl/perl-POE-Component-SNMP.spec
SRPM URL: http://home.comcast.net/~ckweyl/perl-POE-Component-SNMP-1.05-1.fc5.src.rpm

Description: 
POE::Component::SNMP is a POE-ized wrapper around the the Net::SNMP module.
Most of its arguments aren't even evaluated by POE, except for -alias and
-callback_args, as described in the manpage.

If you want to make non-blocking calls with Net::SNMP in a POE application,
this is the module to do it with.

Comment 1 Jason Tibbitts 2006-07-28 03:14:34 UTC

Something's odd with the test suite:

t/10_snmp_get.........POE::Kernel's run() method was never called.
skipped
        all skipped: No SNMP data specified.

Looking deeper, all of the skipped tests require not only network access, but a
running SNMP server to talk to and write to that gets configured when
Makefile.PL is run.  So I guess everything's working as intended.

* source files match upstream:
   d13446b20b21e24c15fd6be406006bec  POE-Component-SNMP-1.05.tar.gz
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible.  License text not included upstream.
* latest version is being packaged.
* BuildRequires are proper (BR: perl is unnecessary)
* %clean is present.
* package builds in mock (development, x86_64).
* rpmlint is silent.
* final provides and requires are sane:
   perl(POE::Component::SNMP)
   perl(POE::Component::SNMP::Dispatcher) = 1.27
   perl(POE::Net::SNMP)
   perl-POE-Component-SNMP = 1.05-1.fc6
  =
   perl(:MODULE_COMPAT_5.8.8)
   perl(Carp)
   perl(POE::Component::SNMP::Dispatcher)
   perl(POE::Kernel)
   perl(POE::Session)
   perl(Time::HiRes)
   perl(base)
   perl(constant)
* %check is present; the test suite doesn't seem to run well but what can run
passes:
   All tests successful, 10 tests skipped.
   Files=11, Tests=4,  2 wallclock secs ( 1.44 cusr +  0.50 csys =  1.94 CPU)

* no shared libraries are present.
* package is not relocatable.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no libtool .la droppings.

APPROVED

Comment 2 Chris Weyl 2006-07-28 04:12:17 UTC

+Import to CVS
+Add to owners.list
+Bump release, build for devel
+devel build succeeds
+Request branching (FC-5)
+Close bug

Thanks for the review!