Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 200664
Summary: | Review Request: soundtouch - Audio Processing library for changing Tempo, Pitch and Playback | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Hans de Goede <hdegoede> | ||||||
Component: | Package Review | Assignee: | Paul F. Johnson <paul> | ||||||
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> | ||||||
Severity: | medium | Docs Contact: | |||||||
Priority: | medium | ||||||||
Version: | rawhide | CC: | bnocera, dtimms | ||||||
Target Milestone: | --- | Flags: | kevin:
fedora-cvs+
|
||||||
Target Release: | --- | ||||||||
Hardware: | All | ||||||||
OS: | Linux | ||||||||
Whiteboard: | |||||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||||
Doc Text: | Story Points: | --- | |||||||
Clone Of: | Environment: | ||||||||
Last Closed: | 2006-08-02 13:11:09 UTC | Type: | --- | ||||||
Regression: | --- | Mount Type: | --- | ||||||
Documentation: | --- | CRM: | |||||||
Verified Versions: | Category: | --- | |||||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
Cloudforms Team: | --- | Target Upstream Version: | |||||||
Embargoed: | |||||||||
Bug Depends On: | |||||||||
Bug Blocks: | 163779 | ||||||||
Attachments: |
|
Description
Hans de Goede
2006-07-30 08:54:59 UTC
Unable to build in mock (x86) - see attachment Builds fine outside of mock and rpmlint is clean (other no documentation warning for the -devel package) Created attachment 133296 [details]
Build log
Hmm, nasty it turns out that soundtouch uses symlinks to instead of copies of some needed automake files. I've fixed this by adding a BR: automake New version here: Spec URL: http://people.atrpms.net/~hdegoede/soundtouch.spec SRPM URL: http://people.atrpms.net/~hdegoede/soundtouch-1.3.1-2.src.rpm Still not building in mock +sed -i 's|^hardcode_libdir_flag_spec.*|hardcode_libdir_flag_spec=""|g' libtool sed: can't read libtool: No such file or directory HMM, could you try changing that BR: automake I added to BR: libtool and see if it builds then. I don't mock because of my sucky internet access. Created attachment 133358 [details]
Altered spec file
Yep. Altering the BR fixed it.
Review Spec file : (based on my modifiction) Good - consistant use of macros, upstream md5 is the same as the tarball, no dupes in the BRs. rpmlint reports clean for all packages (does give no docs in -devel, this can be ignored, not an error). rpm -qa --requires comes up clean (nothing missing) Needs work/Niggle rm -rf $RPM_BUILD_ROOT%{_prefix}/doc/%{name} - why is this going to /usr/doc instead of %{_docdir}? Question sed -i 's|\r||' README.html COPYING.TXT - is this to remove the incorrect termination of the files? I tend to use 's/\r//' (In reply to comment #7) > Needs work/Niggle > rm -rf $RPM_BUILD_ROOT%{_prefix}/doc/%{name} - why is this going to /usr/doc > instead of %{_docdir}? > This is what upstreams Makefile does, thats why its removed and then later added under files with %doc. > Question > sed -i 's|\r||' README.html COPYING.TXT - is this to remove the incorrect > termination of the files? I tend to use 's/\r//' > Same thing you can use any special char after the s in sed not only / but also | or ! or :, etc. This is handy when your search or replace string contains / for example when search replacing file / dir paths using / after the s is a bad idea. Thanks. Can you upload a new srpm with the amended spec file so that it can tested again? New version here (I used your attached spec verbatim): Spec URL: http://people.atrpms.net/~hdegoede/soundtouch.spec SRPM URL: http://people.atrpms.net/~hdegoede/soundtouch-1.3.1-3.src.rpm Thanks. Good: mock builds cleanly rpmlint shows nothing of importance software works md5sums are the same upstream version same no dupes no ownership problems On the condition that you add pkgconfig to the R: on the devel package, I'm happy for this to go in. This was discussed at the start of July on IRC (FESCo) APPROVED Thanks! I've added the Requires: pkgconfig and imported soundtouch. After some strugling building it due to ppc issues its now build too, closing. Package Change Request ====================== Package Name: soundtouch New Branches: EL-5 EL-6 Owners: dtimms I would like to start supporting epel with audacity, and this is a requirement. CVS done (by process-cvs-requests.py). |