Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 201478

Summary:	Review Request: perl-DateTime-Format-IBeat
Product:	[Fedora] Fedora	Reporter:	Chris Weyl <cweyl>
Component:	Package Review	Assignee:	Patrice Dumas <pertusus>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Package Reviews List <fedora-package-review>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
URL:	http://search.cpan.org/dist/DateTime-Format-IBeat
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2006-08-06 16:57:33 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	163779, 201480

Description Chris Weyl 2006-08-06 00:08:33 UTC

SRPM URL: http://home.comcast.net/~ckweyl/perl-DateTime-Format-IBeat-0.161-1.fc5.src.rpm
SPEC URL: http://home.comcast.net/~ckweyl/perl-DateTime-Format-IBeat.spec

Description:
No Time Zones, No Geographical Borders

How long is a Swatch .beat? In short, we have divided up the virtual and real
day into 1000 beats. One Swatch beat is the equivalent of 1 minute 26.4
seconds. That means that 12 noon in the old time system is the equivalent of
500 Swatch .beats.

Comment 1 Patrice Dumas 2006-08-06 11:54:05 UTC

2 remarks (not blockers):

- Since it is a noarch package, OPTIMIZE="%{optflags}" isn't needed
- no need to mv LICENSE, the spec file must be in american 
  english, not the files

* rpmlint is silent
* package named according to guidelines
* free software, licences included
* meets packaging guidelines
* spec legible
* source match upstream
53e1b71382b074c85e12c6b0bf855444  DateTime-Format-IBeat-0.161.tar.gz
* sane provides
Provides: perl(DateTime::Format::IBeat) = 0.161
* BuildRequires constructed according to Makefile.PL
* %files section right

APPROVED

Comment 2 Chris Weyl 2006-08-06 16:57:33 UTC

(In reply to comment #1)
> - Since it is a noarch package, OPTIMIZE="%{optflags}" isn't needed

Dropped those bits post-import.

+Import to CVS
+Add to owners.list
+Bump release, build for devel
+devel build succeeds
+Request branching (FC-4,FC-5)
+Close bug

Thanks for the review! :)