Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 201479

Summary: Review Request: perl-Class-Factory-Util
Product: [Fedora] Fedora Reporter: Chris Weyl <cweyl>
Component: Package ReviewAssignee: Patrice Dumas <pertusus>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Package Reviews List <fedora-package-review>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhide   
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
URL: http://search.cpan.org/dist/Class-Factory-Util
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2006-08-06 17:14:16 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 163779, 201480    

Description Chris Weyl 2006-08-06 00:12:36 UTC
SRPM URL: http://home.comcast.net/~ckweyl/perl-Class-Factory-Util-1.6-1.fc5.src.rpm
SPEC URL: http://home.comcast.net/~ckweyl/perl-Class-Factory-Util.spec

Description:
This module exports utility functions that are useful for factory classes.

Comment 1 Patrice Dumas 2006-08-06 11:31:00 UTC
One remark: the changelog entry isn't formatted with a leading -

* rpmlint is silent
* package named according to guidelines
* free software licence included
* meets packaging guidelines
* spec legible
* md5sum match upstream
88b4471f9c22abcc1192f87be013cc18  ../RPM-fc/SOURCES/Class-Factory-Util-1.6.tar.gz
* sane provides
Provides: perl(Class::Factory::Util) = 1.6
* %files right

APPROVED

Comment 2 Patrice Dumas 2006-08-06 11:46:48 UTC
The combination of GPL and artistic in one file is dubious,
since only verbatim redistribution of the GPL is allowed...
This issue should be taken upstream in my opinion, but is
not a blocker.

Comment 3 Chris Weyl 2006-08-06 17:14:16 UTC
+Import to CVS
+Add to owners.list
+Bump release, build for devel
+devel build succeeds
+Request branching (FC-4, FC-5)
+Close bug

Thanks for the review! :)

(In reply to comment #2)
> The combination of GPL and artistic in one file is dubious,
> since only verbatim redistribution of the GPL is allowed...
> This issue should be taken upstream in my opinion, but is
> not a blocker.

I'll send them a note; I've seen a couple modules do this now but it doesn't
appear to be common practice.