Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 201873
Summary: | Review Request: wmix - Dockapp mixer | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Patrice Dumas <pertusus> |
Component: | Package Review | Assignee: | cq92j9y+rlkr0w |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | ||
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2006-09-06 11:00:55 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779 |
Description
Patrice Dumas
2006-08-09 15:46:10 UTC
Hi Patrice, I'm going to review this now. I apologize for the delay. * Since you're pretty much doing the whole installation process manually, why don't you just copy the 'wmix' binary to %{_bindir} and avoid the use of "make install"? (There's nothing wrong with your current approach, though). REVIEW (wmix-3.1-1) + rpmlint shows no error. + package meets the naming guidelines. + spec-file is properly named. + package meets the packaging guidelines. + package license is open-source compatible (GPL). + license field matches the actual license. + license file included in %doc. + spec file is written in english. + spec file is legible. + source files match upstream: 62f6e86f7558f193e081dc29444a6699 wmix-3.1.tar.gz + package successfully compiled, built and tested on i386 (rawhide). + all build dependencies are listed in BuildRequires. + package doesn't need to use %find_lang (no locales present). + package doesn't contain shared libraries. + package isn't relocatable. + package owns all directories that it creates. + no duplicate files in %files. + file permissions are properly set. + package has a %clean section containing rm -rf %{buildroot}. + package uses macros consistently. + package contains code, not content. + no -doc subpackage needed. + %docs don't affect application runtime. + package doesn't contain headers, static libraries or pkgconfig files (no devel package). + package doesn't own directories owned by other packages. + package builds fine in mock (fedora-development-i386-core). APPROVED Hey Patrice, I see you've imported wmix into cvs. Please don't forget to close this bug as NEXTRELEASE when the package is built. I was away... Built, added to comps, omwners. |