Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 202457
Summary: | Review Request: crack-attack - Puzzle action game | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Hans de Goede <hdegoede> |
Component: | Package Review | Assignee: | Ian Chapman <packages> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-games-list, manuel |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2006-09-03 05:34:32 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779 |
Description
Hans de Goede
2006-08-14 15:51:57 UTC
tested on x86_64 (FC5) builds and works fine here. (nvidia drivers + 7800GTX) one thing I found: rpmlint /home/dragoran/rpm/RPMS/x86_64/crack-attack-1.1.14-7.x86_64.rpm W: crack-attack unstripped-binary-or-object /usr/bin/crack-attack should there be any sound? here I can here nothing. (In reply to comment #1) > tested on x86_64 (FC5) > builds and works fine here. > (nvidia drivers + 7800GTX) > one thing I found: > rpmlint /home/dragoran/rpm/RPMS/x86_64/crack-attack-1.1.14-7.x86_64.rpm > W: crack-attack unstripped-binary-or-object /usr/bin/crack-attack > I ran rpmlint too and it didn't give that warning for me, there seems to be a bug in rpmbuild which sometimes causes this (yes sometimes, strange but true) often a rebuild of the very same srpm / spec will fix it :| (In reply to comment #2) > should there be any sound? > here I can here nothing. Sound would be nice, but isn't included upstream, so you not hearing anything is to be expected :) (In reply to comment #3) > (In reply to comment #1) > > tested on x86_64 (FC5) > > builds and works fine here. > > (nvidia drivers + 7800GTX) > > one thing I found: > > rpmlint /home/dragoran/rpm/RPMS/x86_64/crack-attack-1.1.14-7.x86_64.rpm > > W: crack-attack unstripped-binary-or-object /usr/bin/crack-attack > > > I ran rpmlint too and it didn't give that warning for me, there seems to be a > bug in rpmbuild which sometimes causes this (yes sometimes, strange but true) > often a rebuild of the very same srpm / spec will fix it :| > ok will try to rebuild it > (In reply to comment #2) > > should there be any sound? > > here I can here nothing. > > Sound would be nice, but isn't included upstream, so you not hearing anything is > to be expected :) > ok now the "bad" news : I tested the same rpm on a second box (FC5/UP/x86_64/6600GT) -> the start game button does not launch the game but the same window again. the package versions are not the same as on this box (which works) because there is no internet connection, but it isn't a fresh FC5 install either. (In reply to comment #4) > now the "bad" news : > I tested the same rpm on a second box (FC5/UP/x86_64/6600GT) -> the start game > button does not launch the game but the same window again. > the package versions are not the same as on this box (which works) because there > is no internet connection, but it isn't a fresh FC5 install either. > Hmm, is your other machine 64 bit too? Although I doubt that is the problem, my devel machine is 64 bit. Could you try fully updating the affected machine, maybe some of crackattacks dependencies cause this problem? It also works perfectly on: [root@Arbusto ~]# cat /etc/fedora-release Fedora Core release 5 (Bordeaux) And: [root@Arbusto ~]# lspci | grep -i vga 00:02.0 VGA compatible controller: Intel Corporation 82852/855GM Integrated Graphics Device (rev 02) * rpmlint: no problems * Package named correctly: Yes * Patches named correctly: Yes * Spec file named correctly: Yes * Licence field matches: Yes * Licence file installed: Yes (and included upstream) * Spec file in American English: Yes * Source matches upstream: Yes * Locales use %find_lang: N/A * Contains %clean: Yes * Specfile legible: Yes * Compiles and builds ok: Yes (mock: fc5/ppc) * Calls ldconfig in %post/%postun for shlibs: N/A * Owns directories it creates: Yes * Duplicate files: No * Permissions set correctly: Yes * Consistent macro use: Yes (but see suggestion) * %doc affects runtime: No * Headers and static libs in -devel: N/A * .pc files in -devel: N/A * .so in -devel: N/A * -devel requires base: N/A * Contains .la files: No * Owns files it didn't create: No * .desktop files installed correctly: Yes 1. The URL: tag appears to point to an old site, as the latest version on this site is 1.1.10 and the source location is different. I feel http:// www.nongnu.org/crack-attack/ would be a better choice. 2. No use of %{name}-%{version} macros in Source tag. Personal preference but just a heads up if you prefer to use them. 3. Several files are installed in the %doc directory which probably shouldn't be there: *.sanitize: The patch backup files crack-attack.6: An uncompressed copy of the man page, but the man page is correctly installed in %{_mandir}/man6/ crack-attack.xml: Really a 'source' file for generating the man page so I wouldn't install it. ready_to_release: Useless to the end user IMHO and shouldn't be installed. 4. /usr/share/crack-attack/crack-attack.desktop and /usr/share/crack-attack/ crack-attack.xpm, do these files really need to be there? Everybody / anybody I'm cc-ing fedora-games-list as it looks like this package is going to be reviewed if you have any doubts, really any at all about the legal status of this package please speak up now, before it gets approved, imported and build! (In reply to comment #7) > 1. The URL: tag appears to point to an old site, as the latest version on this > site is 1.1.10 and the source location is different. I feel http:// > www.nongnu.org/crack-attack/ would be a better choice. > Fixed > 2. No use of %{name}-%{version} macros in Source tag. Personal preference but > just a heads up if you prefer to use them. > Missed those in the old specfile I inhereted, fixed. > 3. Several files are installed in the %doc directory which probably shouldn't > be there: > > *.sanitize: The patch backup files > crack-attack.6: An uncompressed copy of the man page, but the man page is > correctly installed in %{_mandir}/man6/ > crack-attack.xml: Really a 'source' file for generating the man page so I > wouldn't install it. > ready_to_release: Useless to the end user IMHO and shouldn't be installed. > Woops, fixed, thanks! > 4. /usr/share/crack-attack/crack-attack.desktop and /usr/share/crack-attack/ > crack-attack.xpm, do these files really need to be there? The .xpm is needed and I've used the .desktop as the .desktop and installed it with --delete-original. New version with all this fixed here: Spec URL: http://people.atrpms.net/~hdegoede/crack-attack.spec SRPM URL: http://people.atrpms.net/~hdegoede/crack-attack-1.1.14-8.src.rpm All fixes verified so as far as I'm concerned the package is APPROVED! Of course, feel free to wait a while before import & build for any reasonable objections from fedora-games-list. It's been almost a week, and I have seen no sign of objection on the fedora- games-list (from looking at the archives at least). I would expect someone would have spoken up by now if there were objections... Thanks all, Imported and build, closing. |