Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 203205
Summary: | Review Request: eclipse-phpeclipse | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Ben Konrath <ben> |
Component: | Package Review | Assignee: | Anthony Green <green> |
Status: | CLOSED DUPLICATE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora, green, rpm |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2006-11-02 06:18:15 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 201449 |
Description
Ben Konrath
2006-08-18 21:14:12 UTC
Is this supposed to build on FC5? I get... BUILD FAILED Buildfile: /usr/share/eclipse/plugins/org.eclipse.pde.build/scripts/build.xml does not exist because this file lives at: /usr/share/eclipse/plugins/org.eclipse.pde.build_3.1.2/scripts/build.xml (In reply to comment #1) > Is this supposed to build on FC5? No, I don't think the source will even compile against 3.1.2. Sorry I should have been clear about that. Let's look at the rpmlint output: E: eclipse-phpeclipse description-line-too-long The PHPeclipse plugin allows developers to write PHP webpages and scripts in Eclipse. I've never seen this before. Should be easy to fix. W: eclipse-phpeclipse non-standard-group Text Editors/Integrated Development Environments (IDE) Please use Development/Tools. W: eclipse-phpeclipse incoherent-version-in-changelog 1.1.8-6 1.1.8-7 This must be a typo. W: eclipse-phpeclipse invalid-license Common Public License (CPL) 1.0 Please just use "CPL". W: eclipse-phpeclipse no-documentation At a minimum, please add the license text as a %doc in the %files section. W: eclipse-phpeclipse hidden-file-or-dir /usr/share/eclipse/plugins/net.sourceforge.phpeclipse.launching_1.1.8/.classpath W: eclipse-phpeclipse hidden-file-or-dir /usr/share/eclipse/plugins/net.sourceforge.phpeclipse.phphelp_1.1.8/.classpath W: eclipse-phpeclipse hidden-file-or-dir /usr/share/eclipse/plugins/net.sourceforge.phpeclipse.debug.core_1.1.8/.project W: eclipse-phpeclipse hidden-file-or-dir /usr/share/eclipse/plugins/net.sourceforge.phpeclipse.debug.core_1.1.8/.template W: eclipse-phpeclipse hidden-file-or-dir /usr/share/eclipse/plugins/net.sourceforge.phpeclipse.debug.core_1.1.8/.classpath W: eclipse-phpeclipse hidden-file-or-dir /usr/share/eclipse/plugins/net.sourceforge.phpeclipse.debug.ui_1.1.8/.template W: eclipse-phpeclipse hidden-file-or-dir /usr/share/eclipse/plugins/net.sourceforge.phpeclipse.launching_1.1.8/.project W: eclipse-phpeclipse hidden-file-or-dir /usr/share/eclipse/plugins/net.sourceforge.phpeclipse.launching_1.1.8/.template I've never seen these before. Can we delete them, or are they important? W: eclipse-phpeclipse one-line-command-in-%post /usr/bin/rebuild-gcj-db W: eclipse-phpeclipse one-line-command-in-%postun /usr/bin/rebuild-gcj-db Use single lines like this instead: %post -p %{_bindir}/rebuild-gcj-db The rest are from the SRPM.... E: eclipse-phpeclipse description-line-too-long The PHPeclipse plugin allows developers to write PHP webpages and scripts in Eclipse. W: eclipse-phpeclipse non-standard-group Text Editors/Integrated Development Environments (IDE) W: eclipse-phpeclipse invalid-license Common Public License (CPL) 1.0 All as above. W: eclipse-phpeclipse mixed-use-of-spaces-and-tabs I just use the emacs untabify command for this. I'd really like to see this review finished and phpeclipse imported and built. Ben, do you intend on addressing these rpmlint suggestions? If not, do you mind if I 'adopt' eclipse-phpeclipse and finish this stalled review? (In reply to comment #4) > Ben, do you intend on addressing these rpmlint suggestions? If not, do you mind > if I 'adopt' eclipse-phpeclipse and finish this stalled review? I don't have the time right now to finish this review so feel free to take it over. It was not easy to get this packaged up so feel free to ping me if you have any questions about this package or if you have problems updating this package to newer versions of phpeclipse when they are released. Thanks. *** This bug has been marked as a duplicate of 213594 *** Marking as bug #201449 |