Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 203212
| Summary: | Review Request: libgalago-gtk | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Brian Pepple <bdpepple> |
| Component: | Package Review | Assignee: | Mamoru TASAKA <mtasaka> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | panemade |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2006-09-23 18:01:58 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 163779 | ||
|
Description
Brian Pepple
2006-08-18 23:16:47 UTC
{Not Official Reviewer}
packaging looks ok.
+ Mockbuild is successfull for i386 FC6
+ rpmlint on binary rpm is silent
+ dist tag is present
+ Buildroot is correct
- source URL is Wrong
+ BR is correct
+ License used is LGPL
+ License file COPYING is included
+ devel package is handled correctly
- MD5 sum on tarball is matching upstream tarball
source tarball name is libgalago-gtk in SPEC whereas upstream tarball name is
libgalago only.
+ No duplicate files
Not tested package
(In reply to comment #1) > - source URL is Wrong Uhmm, no. http://www.galago-project.org/files/releases/source/libgalago-gtk/libgalago-gtk-0.5.0.tar.bz2, which is the same as the spec file. > - MD5 sum on tarball is matching upstream tarball > source tarball name is libgalago-gtk in SPEC whereas upstream tarball name is libgalago only. Uhmm, no again. The name of the tarball is libgalago-gtk-0.5.0.tar.bz2, which matches the spec file. ohh sorry something i did mistakenly. First with wget command it failed and when i check actual URL i wrongly clicked on libgalago dir instead libgalago-gtk. anyway there is no problem in packaging. SOURCE URL matches upstream tarball with 20e809869ec764efb2259ee0d0dee263 libgalago-gtk-0.5.0.tar.bz2 1. From http://fedoraproject.org/wiki/Packaging/Guidelines: * Use rpmlint - rpmlint is not silent. W: libgalago-gtk mixed-use-of-spaces-and-tabs (in src.rpm) W: libgalago-gtk-devel no-documentation - Remove tabs from spec file to unify spacing. - The latter rpmlibt conmplaint can be ignored, I think. * Timestamps - Use: make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -c -p" to keep the timestamps of header files in -devel package. 2. From http://fedoraproject.org/wiki/Packaging/ReviewGuidelines : = Nothing. ping? (In reply to comment #4) > W: libgalago-gtk mixed-use-of-spaces-and-tabs (in src.rpm) > W: libgalago-gtk-devel no-documentation > > - Remove tabs from spec file to unify spacing. > - The latter rpmlibt conmplaint can be ignored, I think. In my opinion both of these warnings can be ignored. > > * Timestamps > - Use: > make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -c -p" > to keep the timestamps of header files in -devel package. I also think that this can be ignored, but I would like to hear from other FE contributors to get their opinion on this. (In reply to comment #6) > > * Timestamps > > - Use: > > make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -c -p" > > to keep the timestamps of header files in -devel package. > > I also think that this can be ignored, but I would like to hear from other FE > contributors to get their opinion on this. > I usually recommend to keep timestamp if possible, especially when the package contains a lot of files which were originally included in the source and not created during compilation stage. Keeping timestamp make it clearer if packager (like you) made some fixes or changes against the files, IMO. Spec URL: http://piedmont.homelinux.org/fedora/libgalago/libgalago-gtk.spec SRPM URL: http://piedmont.homelinux.org/fedora/libgalago/libgalago-gtk-0.5.0-2.src.rpm * Sat Sep 23 2006 Brian Pepple <bpepple> - 0.5.0-2 - Preserve timestamps of header files. Okay. -------------------------------------------------------------- This package (libgalago-gtk) is APPROVED by me. |