Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 203249
Summary: | Review Request: kpolynome | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Chitlesh GOORAH <chitlesh> |
Component: | Package Review | Assignee: | Mamoru TASAKA <mtasaka> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | mtasaka |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2006-08-26 17:33:38 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779 |
Description
Chitlesh GOORAH
2006-08-19 19:32:09 UTC
Quick, not-official review: * mock build fails. You have to add autoconf and automake BRs. * rpmlint gives a lot of output: E: kpolynome script-without-shellbang /usr/share/doc/kpolynome-0.1.2/AUTHORS W: kpolynome dangling-symlink /usr/share/doc/HTML/en/kpolynome/common /usr/ share/doc/HTML/en/common W: kpolynome symlink-should-be-relative /usr/share/doc/HTML/en/kpolynome/common /usr/share/doc/HTML/en/common E: kpolynome zero-length /usr/share/doc/kpolynome-0.1.2/README E: kpolynome script-without-shellbang /usr/share/doc/kpolynome-0.1.2/NEWS W: kpolynome dangling-symlink /usr/share/doc/HTML/hu/kpolynome/common /usr/ share/doc/HTML/hu/common W: kpolynome symlink-should-be-relative /usr/share/doc/HTML/hu/kpolynome/common /usr/share/doc/HTML/hu/common E: kpolynome script-without-shellbang /usr/share/doc/kpolynome-0.1.2/COPYING E: kpolynome script-without-shellbang /usr/share/doc/kpolynome-0.1.2/ChangeLog You should change doc files permissions in %%prep section and probably remove README file. I forgot to look into %%files section in your spec file. There is a few things you have to correct. Your package doesn't own directories that it creates. For example, RPM creates %{_datadir}/apps/%{name} directory, but during uninstall, it won't be deleted. Why? Because it is refering to file (%{name}ui.rc), not directory. Idem with HTML-doc files. You have to refer to whole directory, not to particular files. So, your %%files section should look like: %{_datadir}/apps/%{name} %{_docdir}/HTML/en/%{name} etc. Updated: Spec URL: http://chitlesh.funpic.de/rpm/kpolynome.spec SRPM URL: http://chitlesh.funpic.de/rpm/kpolynome-0.1.2-2.src.rpm Well, only for packaging issue. mock build is okay. * %post and %postun calls %{_bindir}/gtk-update-icon-cache. Require it as Requires(post) and Requires(postun). * %patch0 -p0 -b . Very cosmetic, however, adding some suffix is perhaps preferable. * chmod 644 %{_builddir}/%{name}-0.1/AUTHORS Why the explicit directory %{_builddir}/%{name}-0.1 necessary? Usually, in %build or %install stage, the working directory is what is written in %setup stage. * Any reasons that document HTML files should be in %{_docdir}/HTML/??/%{name} ? On my system, the only rpm which uses %{_docdir}/HTML/ is fedora-release-notes. Documents in other rpms should be in %{_docdir}/%{name}-%{version}. I suggest moving HTML document files. * rpmlint is not silent. E: kpolynome-debuginfo script-without-shellbang /usr/src/debug/kpolynome-0.1/src/drawwidget.h E: kpolynome-debuginfo script-without-shellbang /usr/src/debug/kpolynome-0.1/src/maindialog.h E: kpolynome-debuginfo script-without-shellbang /usr/src/debug/kpolynome-0.1/src/drawwidget.cpp E: kpolynome-debuginfo script-without-shellbang /usr/src/debug/kpolynome-0.1/src/maindlg.ui.h E: kpolynome-debuginfo script-without-shellbang /usr/src/debug/kpolynome-0.1/src/matdata.cpp E: kpolynome-debuginfo script-without-shellbang /usr/src/debug/kpolynome-0.1/src/curvedialog.h E: kpolynome-debuginfo script-without-shellbang /usr/src/debug/kpolynome-0.1/src/main.cpp E: kpolynome-debuginfo script-without-shellbang /usr/src/debug/kpolynome-0.1/src/curvedialog.cpp E: kpolynome-debuginfo script-without-shellbang /usr/src/debug/kpolynome-0.1/src/matdata.h E: kpolynome-debuginfo script-without-shellbang /usr/src/debug/kpolynome-0.1/src/maindialog.cpp E: kpolynome-debuginfo script-without-shellbang /usr/src/debug/kpolynome-0.1/src/curvedlg.ui.h --- permission issue. Fix this by changing the permissions of these files to 644. Updated: Spec URL: http://chitlesh.funpic.de/rpm/kpolynome.spec SRPM URL: http://chitlesh.funpic.de/rpm/kpolynome-0.1.2-3.src.rpm rpmlint became clean. I think that this package is almost okay. Assigning to me. Well: * HTML documents [tasaka1@localhost SOURCES]$ rpm -ql kpolynome /usr/bin/kpolynome /usr/share/applications/fedora-kpolynome.desktop /usr/share/apps/kpolynome /usr/share/apps/kpolynome/kpolynomeui.rc /usr/share/doc/kpolynome-0.1.2 /usr/share/doc/kpolynome-0.1.2/AUTHORS /usr/share/doc/kpolynome-0.1.2/COPYING /usr/share/doc/kpolynome-0.1.2/ChangeLog /usr/share/doc/kpolynome-0.1.2/NEWS /usr/share/doc/kpolynome-0.1.2/TODO /usr/share/icons/hicolor/16x16/apps/kpolynome.png /usr/share/icons/hicolor/32x32/apps/kpolynome.png ...... All HTML docs disappeared. I think you forgot to add some entry to %doc. * Changelog %changelog * Fri Aug 25 2006 Chitlesh Goorah - Fixed xcircuit.desktop I think this is only a typo. * chmod -x src/{drawwidget.*,maindi ..... Umm, well, it is okay, however, $ find . -name \*.cpp -o -name \*.h | xargs chmod 0644 (pwd is $builddir/kpolynome-0.1.2) in %prep stage is perhaps simpler. * Requires: kdelibs is necessary? This package requires libkdecore.so.4 and this correctly requires kdelibs. Updated: Spec URL: http://chitlesh.funpic.de/rpm/kpolynome.spec SRPM URL: http://chitlesh.funpic.de/rpm/kpolynome-0.1.2-4.src.rpm Moving to final check. A question: Would you check the files in /usr/share/doc/kpolynome-0.1.2/{en,hu}/ , especially Makefile* in that directory necessary? Updated: Spec URL: http://chitlesh.funpic.de/rpm/kpolynome.spec SRPM URL: http://chitlesh.funpic.de/rpm/kpolynome-0.1.2-5.src.rpm Fully checked. The remained things are: From http://fedoraproject.org/wiki/Packaging/Guidelines : * Requires Requires: kdelibs Again, why is this exclicit requirement needed? /usr/bin/kpolynome requires libkdecore.so.4 and this is included in kdelibs. So this package automatically requires kdelibs even without the explicit statement above is not written. I suspect that the sentence can be removed. * Using %{buildroot} and %{optflags} vs $RPM_BUILD_ROOT and $RPM_OPT_FLAGS You use both %{_builddir} and $RPM_BUILD_ROOT . Choose one (although this is very cosmetic). Other thing are all okay. Updated: Spec URL: http://chitlesh.funpic.de/rpm/kpolynome.spec SRPM URL: http://chitlesh.funpic.de/rpm/kpolynome-0.1.2-6.src.rpm %Changelog - 0.1.2-6 - Replaced $$RPM_BUILD_ROOT by %%{buildroot} - Removed requires: kdelibs Okay. Now I am pleased to say that this package (kpolynome) is APPROVED. |