Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 203265
| Summary: | Review Request: nqc - Programming environment for Lego's RCX (Mindstorms) bricks | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Rick L Vinyard Jr <rvinyard> |
| Component: | Package Review | Assignee: | Paul F. Johnson <paul> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | ||
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2006-08-21 00:47:32 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 163779 | ||
|
Description
Rick L Vinyard Jr
2006-08-20 01:02:48 UTC
Simon's original submission is here: http://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=185205 %{_sbindir}/groupadd
You don't have anything in Requires(pre) for this (or the similar one in postun)
rpmlint warnings
.src.rpm : mixed used of spaces and tabs
rpm : non-conffile-in-etc /etc/udev/rules.d/60-legousbtower.rules
dangerous-command-in-%postun groupdel
I'm not worried about the src.rpm warning, but am about the two in the rpm
(especially the dangerous command one).
Fails to build in mock
/bin/sh: flex: command not found
*** Bug 185205 has been marked as a duplicate of this bug. *** Please remove the groupdel from the next iteration of the spec file - it's a recipe for disaster. Does the %pre check to ensure that lego doesn't already exist first? It looks like it does. Spec URL: http://miskatonic.cs.nmsu.edu/pub/nqc.spec SRPM URL: http://miskatonic.cs.nmsu.edu/pub/fedora/5/srpms/nqc-3.1.4-2.src.rpm Changes: - Removed groupdel lego - Added faq, manual and guide docs - Added flex BuildRequires and groupadd Requires(pre) - Added -f option to groupadd (success if group exists) It build fine in mock (x86_64) now. Also, I tested the groupadd -f option to ensure that it doesn't have any problems with the group if it's already present. Builds fine in mock. It's 19:37 in the UK which can mean only one thing, it's time for the official UK review procedure... (cue naff 90's music trying to sounds like crumby '06 noises) At 10... No ownership problems rpmlint is clean (well, spaces/tabs in srpm and config file in rpm) builds clean in mock (i386) No dupes No devel, so no pkgconfig, no .so/.la problems software does as it should no problems with documentation consistent use of macros upstream matches the package (version and md5) works fine with smp_mflags And this weeks number 1... It controls the lego! (fade really terrible music) APPROVED |