Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 203286

Summary:	Review Request: sjasm - A z80 cross assembler
Product:	[Fedora] Fedora	Reporter:	Ian Chapman <packages>
Component:	Package Review	Assignee:	Hans de Goede <hdegoede>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Package Reviews List <fedora-package-review>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	hdegoede
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2006-08-20 23:32:03 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	163779

Description Ian Chapman 2006-08-20 17:04:23 UTC

Spec URL: http://dribble.org.uk/reviews/sjasm.spec
SRPM URL: http://dribble.org.uk/reviews/sjasm-0.39-0.3.g1.src.rpm
Description: 
SjASM is a two pass macro Z80 cross assembler

Comment 1 Hans de Goede 2006-08-20 17:27:09 UTC

MUST:
=====
* rpmlint output is clean
* Package and spec file named appropriately
* Packaged according to packaging guidelines
* License ok (but license file not included)
* spec file is legible and in Am. English.
* Source matches upstream
* Compiles and builds on FC-5 i386
* BR: ok
* No locales
* No shared libraries
* Not relocatable
* Package owns / or requires all dirs
* No duplicate files & Permissions ok
* %clean & macro usage OK
* Contains code only
* %doc does not affect runtime, and isn't large enough to warrent a sub package
* no -devel package needed, no libs / .la files.
* no .desktop file required

Approved!

Comment 2 Ian Chapman 2006-08-20 23:23:06 UTC

Thanks for the review!