Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 204121
Summary: | Review Request: tremulous - First Person Shooter game based on the Quake 3 engine | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Hans de Goede <hdegoede> |
Component: | Package Review | Assignee: | Matthias Saou <matthias> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | green, lemenkov, matthias, wart |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2006-09-06 06:35:26 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779 |
Description
Hans de Goede
2006-08-25 18:28:03 UTC
Preliminary comments : - I would rename the tarball to something different from upstream in order to make it impossible to get both confused, ever. Something like %{name}-%{version}-src-nolcc.tar.gz maybe? - The desktop file needs tremulous.xpm changed to tremulous.png - You have -m64 in the BASE_CFLAGS set by your patch (probably unwanted even though the spec file overrides it) - Matthias takes two T's (%changelog) :-) (In reply to comment #1) > Preliminary comments : > - I would rename the tarball to something different from upstream in order to > make it impossible to get both confused, ever. Something like > %{name}-%{version}-src-nolcc.tar.gz maybe? Done > - The desktop file needs tremulous.xpm changed to tremulous.png Fixed > - You have -m64 in the BASE_CFLAGS set by your patch (probably unwanted even > though the spec file overrides it) Hmm, that probably is a left over from your or Warts sed s/// approach to fixing the CFLAGS, its really harmless as it the affected part of the makefile only gets used on SunOS :) Anyways I've pruned this and a few other unneeded changes from the patch. > - Matthias takes two T's (%changelog) :-) Oops, fixed Here is a new version with all this fixed: Spec URL: http://people.atrpms.net/~hdegoede/tremulous.spec SRPM URL: http://people.atrpms.net/~hdegoede/tremulous-1.1.0-2.src.rpm Great. Formal review now :-) - rpmlint is silent, good - fully GPL licensed, with GPL compatible bits, good - name, spec file, sources seem all fine, good - builds fine on both i386 and x86_64, good - runs fine (menu, start a new server, enter the game), good All other MUST/SHOULD items seem good too... APPROVED. Thanks! Imported and build, closing. |