Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 204151
Summary: | Review Request: perl-File-NFSLock - Perl module to do NFS (or not) locking | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Patrice Dumas <pertusus> |
Component: | Package Review | Assignee: | Chris Weyl <cweyl> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | ppisar, xavier |
Target Milestone: | --- | Flags: | kevin:
fedora-cvs+
|
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2006-08-29 12:02:59 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779 |
Description
Patrice Dumas
2006-08-25 21:25:53 UTC
I see there's an examples directory/script, but it's not included in %doc. Let's include that, and this package is approved. + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written and uses macros consistently. + dist tag is present. + build root is correct. + license field matches the actual license. + license is open source-compatible. License text not included upstream. + source files match upstream: 68bddc5e2c32d9748ae689f398fc1147 File-NFSLock-1.20.tar.gz 68bddc5e2c32d9748ae689f398fc1147 File-NFSLock-1.20.tar.gz.srpm + latest version is being packaged. + BuildRequires are proper. + package builds in mock (5/x86_64) + rpmlint is silent. + final provides and requires are sane: ** perl-File-NFSLock-1.20-1.fc5.noarch.rpm == rpmlint == provides perl(File::NFSLock) = 1.20 perl-File-NFSLock = 1.20-1.fc5 == requires perl(:MODULE_COMPAT_5.8.8) perl(Carp) perl(Exporter) perl(strict) perl(vars) + package is not relocatable. + owns the directories it creates. + doesn't own any directories it shouldn't. + no duplicates in %files. + file permissions are appropriate. + %clean is present. + %check is present and all tests pass: All tests successful. Files=12, Tests=161, 42 wallclock secs ( 0.69 cusr + 0.82 csys = 1.51 CPU) + no scriptlets present. + code, not content. + documentation is small, so no -docs subpackage is necessary. + %docs are not necessary for the proper functioning of the package. + no headers. + no pkgconfig files. + no libtool .la droppings. + not a GUI app. + not a web app. examples added with chmod -x: http://www.environnement.ens.fr/perso/dumas/fc-srpms/perl-File-NFSLock-1.20-1.src.rpm (In reply to comment #2) > examples added with chmod -x: Wrong url, it is http://www.environnement.ens.fr/perso/dumas/fc-srpms/perl-File-NFSLock-1.20-2.src.rpm APPROVED Built in devel. Thanks for the review. I don't plan on doing a FC5 release except if somebody asks for it. So requested :) *** Bug 1112166 has been marked as a duplicate of this bug. *** Package Change Request ====================== Package Name: perl-File-NFSLock New Branches: el6 epel7 Owners: xavierb InitialCC: perl-sig As requested in bug #1112166. Git done (by process-git-requests). |