Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 204164
Summary: | Review Request: perl-LWP-Authen-Wsse - Library for enabling X-WSSE authentication in LWP | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Patrice Dumas <pertusus> |
Component: | Package Review | Assignee: | Jason Tibbitts <j> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | ||
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2006-09-06 10:02:14 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779 |
Description
Patrice Dumas
2006-08-26 09:14:31 UTC
This fails to build for me due to failing tests; I added a BR: perl(Digest::SHA1) and things are fine. I'll work up a review. I'll assume that the BuildRequires: perl(Digest::SHA1) is added to the spec for the purposes of this review. * source files match upstream: d611b72884406ed92b7920be76bb3a94 LWP-Authen-Wsse-0.05.tar.gz * package meets naming and packaging guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is correct. * license field matches the actual license. * license is open source-compatible. License text not included upstream. * latest version is being packaged. O BuildRequires are proper (BR: perl is not necessary; assuming BR: perl(Digest::SHA1) is there). * %clean is present. * package builds in mock (development, x86_64). * rpmlint is silent. * final provides and requires are sane: perl(LWP::Authen::Wsse) perl-LWP-Authen-Wsse = 0.05-1.fc6 = perl >= 0:5.004 perl(:MODULE_COMPAT_5.8.8) perl(Digest::SHA1) perl(English) perl(MIME::Base64) perl(constant) perl(strict) perl(warnings) * %check is present and the single test passes: All tests successful. Files=1, Tests=1, 0 wallclock secs ( 0.01 cusr + 0.02 csys = 0.03 CPU) * package is not relocatable. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no libtool .la droppings. APPROVED, assuming you add that missing BR. I have - Add BuildRequires perl(Digest::SHA1) perl(MIME::Base64) in the package I have just imported. Thanks for the review. I'll build it and close the bug when the buildsys becomes more responsive... |