Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 204258
| Summary: | Review Request: mousepad - A simple text editor for Xfce | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Kevin Fenzi <kevin> |
| Component: | Package Review | Assignee: | Christoph Wickert <cwickert> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | orion, panemade |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2006-09-03 03:35:16 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 163779 | ||
|
Description
Kevin Fenzi
2006-08-27 21:01:12 UTC
{Not a official review}
packaging looks ok.
+ Mockbuild is successfull for i386 FC6 but suggests
*** Desktop database not updated. Remember to run:
***
*** update-desktop-database /usr/share/applications
***
More on that check at
http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#head-de6770dd9867fcd085a73a4700f6bcd0d10294ef
desktop-database section
+ rpmlint on binary rpm is silent
+ dist tag is present
+ Buildroot is correct
+ source URL is correct
+ BR is correct
+ License used is GPL
+ License file COPYING is included
+ Desktop file is handled correctly
+ MD5 sum on tarball is matching upstream tarball
f8c23b1de6d23927729c477689883c38 mousepad-0.2.6.tar.bz2
+ No duplicate files
+ Desktop file handled correctly
Thanks Parag. Updated to add 'update-desktop-database': Spec URL: http://www.scrye.com/~kevin/extras/mousepad/mousepad.spec SRPM URL: http://www.scrye.com/~kevin/extras/mousepad/mousepad-0.2.6- 2.fc6.src.rpm I'd like to review this one. REVIEW for 3e94740de010b2285fc8711336538fe6 mousepad-0.2.6-2.fc6.src.rpm MUST items: OK - rpmlint quite on all packages OK - package meets naming guidelines OK - spec file meets naming guidelines OK - package meets package guidelines OK - license open-source compatible (GPL) OK - license in specfile matches actual license OK - license included in %doc OK - spec file in American English OK - spec file is legible OK - source in SRPM matches upstream source (md5 f8c23b1de6d23927729c477689883c38) OK - package builds on i386 OK - all build dependencies listed BuildRequires OK - none of the exceptions of packaging guidelines in BuildRequires OK - locales handled correctly with %find_lang OK - no shared libs OK - package is not relocatable OK - package owns all directories that it creates OK - no duplicate files in %files section OK - permissions and %defattr correct OK - clean section with "rm -rf $RPM_BUILD_ROOT" present OK - macro usage consistent OK - code, not content OK - no large docs OK - docs don't affect runtime OK - no headers or static libs OK - no pkgconfig files OK - no libtool archives OK - mousepad.desktop included and correctly installed OK - package doesn't own files/directories owned by other packages SHOULD items: OK - package builds in mock (Core 5 and 6) OK - package functions as described OK - mime type correctly installed with scriptlet from wiki OK - package uses disttag APPROVED Note: Don't forget Requires(post): desktop-file-utils Requires(postun): desktop-file-utils if you are planning to build this for Core 4 Thanks for the review. Imported and built for devel. 15890 (mousepad): Build on target fedora-development-extras succeeded. Package Change Request ====================== Package Name: mousepad New Branches: el6 Owners: kevin InitialCC: We agreed to not do this one at this time. |