Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 2049808
| Summary: | Review Request: awscli-2 - Universal Command Line Environment for AWS, Version 2 | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | David Duncan <davdunc> |
| Component: | Package Review | Assignee: | Michel Lind <michel> |
| Status: | CLOSED DUPLICATE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | bperkins, davdunc, frh+fedora, gwync, kyleknap, mhayden, michel, nforro, ngompa13, package-review, spotrh, ttomecek, yann.soubeyrand |
| Target Milestone: | --- | Keywords: | Reopened |
| Target Release: | --- | Flags: | ppisar:
fedora-review?
|
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2023-04-25 07:33:36 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 2049689, 2179888 | ||
| Bug Blocks: | |||
|
Description
David Duncan
2022-02-02 17:54:37 UTC
This depends on awscrt, marked it as a blocker. Meanwhile: - why rename this to awscli-2 ? If the intention is that both are parallel installable, this should not obsolete the other. If not, then you can just call this awscli (and actually, don't need a review request) - missing %license LICENSE.txt - with auto build requirement, you only need python3-devel. Drop toml and wheel, they should be automatically picked up - drop python_provide, it's deprecated: https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_deprecated_macros - there are tests, you probably want a %check section. If invoking %tox is too much of a work, invoking %pytest should work. See https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_tests (In reply to Michel Alexandre Salim from comment #1) > This depends on awscrt, marked it as a blocker. Meanwhile: > > - why rename this to awscli-2 ? If the intention is that both are parallel > installable, this should not obsolete the other. If not, then you can just > call this awscli (and actually, don't need a review request) it's a separate package. We have to maintain the original awscli package because it is in RHEL and needs to stay consistent for the foreseeable future. We will need to maintain the two tracks because they function in very different ways. > - missing %license LICENSE.txt whoops! > - with auto build requirement, you only need python3-devel. Drop toml and > wheel, they should be automatically picked up > - drop python_provide, it's deprecated: > https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/ > #_deprecated_macros Thank you. some careless copying of old process. > - there are tests, you probably want a %check section. If invoking %tox is > too much of a work, invoking %pytest should work. See > https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_tests I think kyle can figure this out for me. Thanks. This is an automatic action taken by review-stats script. The ticket submitter failed to clear the NEEDINFO flag in a month. As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews we consider this ticket as DEADREVIEW and proceed to close it. This not stalled... Here are some more important issues: > Name: %{appname}-2 I don't think this is a valid name. Packaging Guidelines say about packages with the same base name [1]: If the base package name does not end with a digit, the version MUST be directly appended to the package name with no intervening separator. > License: ASL 2.0 and MIT This should be: License: Apache-2.0 AND MIT You should also explicitly state in a comment which source files are under MIT (since majority of them are under Apache-2.0). > Patch0: awscli-2.patch Existence of this patch should be justified. The package doesn't build. It does build after updating to the latest upstream version (2.11.6) and removing the downstream patch and version cap of prompt-toolkit, but the test suite ends with: = 96 failed, 64530 passed, 4 skipped, 3 warnings, 97 errors in 518.31s (0:08:38) = [1] https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#multiple Closing this in favor of bug #2189420. *** This bug has been marked as a duplicate of bug 2189420 *** |