Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 205029
Summary: | Review Request: autobuild-applet - a GNOME applet for monitoring Test-AutoBuild build status | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Daniel Berrangé <berrange> |
Component: | Package Review | Assignee: | Brian Pepple <bdpepple> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | ||
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2006-09-07 18:42:50 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779 |
Description
Daniel Berrangé
2006-09-02 16:27:19 UTC
Couple of quick items: 1. Desktop file is incorrectly handled. Refer to http://fedoraproject.org/wiki/Packaging/Guidelines#head-254ddf07aae20a23ced8cecc219d8f73926e9755 2. Duplicate BuildRequires: gtk2-devel (provided by libgnomeui-devel) 3. Unnecessary Requires: python, libgnome, libgnomeui. sonames from devel packages should pull these in. 4. Missing necessary requires on GConf for schemas installation, and probably should use the standard gconf scriptlets for FE packages. Refer to http://fedoraproject.org/wiki/Packaging/ScriptletSnippets?action=show&redirect=ScriptletSnippets#head-6c2101d8f810cc95c677c8c27f43573b0bc23cb1 Minor: 1. Preferred buildroot. http://fedoraproject.org/wiki/Packaging/Guidelines#head-f196e7b2477c2f5dd97ef64e8eacddfb517f1aa1 If I get some free time this weekend I'll try to do a more formal review. Updated SRPM at http://berrange.com/~dan/fedora-review/autobuild-applet/autobuild-applet-1.0.3-2.src.rpm Updated SPEC at http://berrange.com/~dan/fedora-review/autobuild-applet/autobuild-applet.spec Addressed the issues: 1. Fixed the desktop file handling to be compliant with standards 2. Remove duplicate buildrequires 3. Removed the unnecessary requires 4. Added missing requires on gconf & missing pre/preun scripts to comply with standards. NB, I didn't put in the 'killall -HUP gconfd-2' bit, because according to bug 173869 this should no longer be needed 5. Fixed up BuildRoot tag. I also added patch to deal with a gconf handling bug in upstream autobuild-applet sources which was exposed when I tested on FC6test2. MD5Sums: f199953fc6db531716ede26b2a096480 autobuild-applet-1.0.3.tar.gz Good: * Source URL is canonical * Upstream source tarball verified * Package name conforms to the Fedora Naming Guidelines * Group Tag is from the official list * Buildroot has all required elements * All paths begin with macros * All directories are owned by this or other packages * All necessary BuildRequires listed. * All desired features are enabled * Builds in mock fine Minor: * rpmlint gives the following error: W: autobuild-applet non-conffile-in-etc /etc/gconf/schemas/autobuild-applet.schemas +1 APPROVE, and I'll also be you sponsor. http://fedoraproject.org/wiki/Extras/Contributors#head-bb3314e7b80fd98f037edd46f6d1efafbb611752 Has this been built yet? If so, this bug can be closed. http://fedoraproject.org/wiki/Extras/Contributors#head-6b9db491a77039613eb0ba70b30fedb4b73eb7b9 There was a little delay before I got access to plague. The RPM finally got built yesterday and should now be in rawhide |