Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 205043
Summary: | Review Request: geda-gattrib - Attribute editor for gEDA | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Chitlesh GOORAH <chitlesh> |
Component: | Package Review | Assignee: | Mamoru TASAKA <mtasaka> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | hdegoede, mtasaka, sdb, wk |
Target Milestone: | --- | Flags: | kevin:
fedora-cvs+
|
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2006-09-06 09:46:39 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779 |
Description
Chitlesh GOORAH
2006-09-02 22:04:56 UTC
*** Bug 177413 has been marked as a duplicate of this bug. *** First review of geda-gattrib. 1. From http://fedoraproject.org/wiki/Packaging/Guidelines : * BuildRequires: - libpng-devel <- required by gd-devel <- required by libgeda-devel * Desktop files: - No icon is installed in a proper directory. fedora-gattrib.desktop says that "gattrib.{png,xpm}" should be installed in a proper directory. 2. From http://fedoraproject.org/wiki/Packaging/ReviewGuidelines : = Nothing. 3. Other things I have noticed : = Nothing. Updated: Spec URL: http://chitlesh.funpic.de/rpm/geda-gattrib.spec SRPM URL: http://chitlesh.funpic.de/rpm/geda-gattrib-20060123-4.src.rpm Well; I just wondered why no icon are shown on Gattrib menu and I found the problem. Source1 has a typo: icon=gattrib should be Icon=gattrib . Just fix it. Then I recheck if a proper icon appears on Gattrib menu. Updated: Spec URL: http://chitlesh.funpic.de/rpm/geda-gattrib.spec SRPM URL: http://chitlesh.funpic.de/rpm/geda-gattrib-20060824-1.src.rpm Example: gattrib /usr/share/gEDA/examples/RF_Amp/RF_Amp/MSA-2643.sch Well... [tasaka1@dhcp151 geda-gattrib]$ gattrib /usr/share/gEDA/examples/RF_Amp/RF_Amp/MSA-2643.sch gEDA/gattrib version 20060824 gEDA/gattrib comes with ABSOLUTELY NO WARRANTY; see COPYING for more details. This is free software, and you are welcome to redistribute it under certain conditions; please see the COPYING file for more details. Loading file [/usr/share/gEDA/examples/RF_Amp] Couldn't load schematic [/usr/share/gEDA/examples/RF_Amp] No components found in entire design! Do you have refdeses on your components? Exiting. . . . What does this mean? I am the author of this program. Well... [tasaka1@dhcp151 geda-gattrib]$ gattrib /usr/share/gEDA/examples/RF_Amp/RF_Amp/MSA-2643.sch gEDA/gattrib version 20060824 gEDA/gattrib comes with ABSOLUTELY NO WARRANTY; see COPYING for more details. This is free software, and you are welcome to redistribute it under certain conditions; please see the COPYING file for more details. Loading file [/usr/share/gEDA/examples/RF_Amp] Couldn't load schematic [/usr/share/gEDA/examples/RF_Amp] No components found in entire design! Do you have refdeses on your components? Exiting. . . . What does this mean? This is the correct behavior. You tried loading a non-existant file. The path "/usr/share/gEDA/examples/RF_Amp/RF_Amp/MSA-2643.sch" probably doesn't exist. You probably want "/usr/share/gEDA/examples/RF_Amp/MSA-2643.sch" (remove one RF_Amp from diretory list). In general, gattrib will try to open your .sch file and look for valid components. If it can't find then, it will bail out with the above error message. I agree that the error message might be improved to say "file not found" in this case. I can add that to the list of improvements I intend to do. Stuart Brorson (In reply to comment #7) > This is the correct behavior. You tried loading a non-existant file. The > path "/usr/share/gEDA/examples/RF_Amp/RF_Amp/MSA-2643.sch" probably doesn't > exist. You probably want "/usr/share/gEDA/examples/RF_Amp/MSA-2643.sch" > (remove one RF_Amp from diretory list). > > In general, gattrib will try to open your .sch file and look for valid > components. If it can't find then, it will bail out with the above error > message.> > I agree that the error message might be improved to say "file not found" in > this case. I can add that to the list of improvements I intend to do. > > Stuart Brorson > Hello, Stuart. Oops... Actually /usr/share/gEDA/examples/RF_Amp/RF_Amp/MSA-2643.sch wasn't exist... my bad...... Well, I installed geda-examples (I have not accepted geda-examples yet) and it seems to go right. Okay, then I recheck this package again. Thank you. Okay. No problem. This package (geda-gattrib) is APPROVED by me. New Package CVS Request ======================= Package Name: geda-gattrib Short Description: Attribute editor for gEDA Owners: chitlesh Branches: EL-5 cvs done. Sorry Kevin you haven't created the EL-5 branch for geda-gattrib. Sorry, it was done in pkgdb, but for some reason didn't setup right on cvs. Try now? I think I have it fixed. thanks it's fine now. |