Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 205886
| Summary: | Review Request: perl-File-MMagic-XS - Guess file type with XS | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Tom "spot" Callaway <tcallawa> | ||||
| Component: | Package Review | Assignee: | Jason Tibbitts <j> | ||||
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Package Reviews List <fedora-package-review> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | ||||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2006-09-21 17:40:21 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 163779 | ||||||
| Attachments: |
|
||||||
|
Description
Tom "spot" Callaway
2006-09-09 15:48:56 UTC
rpmlint says: W: perl-File-MMagic-XS invalid-license Apache rpmlint would prefer "Apache Software License". E: perl-File-MMagic-XS useless-explicit-provides perl(File::MMagic::XS) Another rpm screwup; somehow it adds the module twice to the provides list, both with and without a version. In the past this has always required a filter. Returning to the subject of the license, I'm not sure that it's clear that the entire package is under the Apache license. The parts that came from Apache are clear, the public domain parts are indicated as such, but some of it is just "All rights reserved" (see lib/File/MMagic/XS.pm) which seems problematic. Fixed the rpmlint warning and error. As to the license, I've emailed the upstream author for clarification, but I suspect that the few files missing license attribution are indeed Apache, due to the fact that this code is just a port to perl of existing Apache licensed code. Created attachment 136002 [details]
Fixed spec file
You're the license czar so if you feel comfortable importing this then I have no objections. * source files match upstream: b8ce9617527a999c85d54fc8a4e88ebc File-MMagic-XS-0.08.tar.gz * package meets naming and packaging guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is correct. ? license field matches the actual license. * license is open source-compatible. License text not included upstream. * latest version is being packaged. * BuildRequires are proper. * compiler flags are appropriate. * %clean is present. * package builds in mock (development, x86_64). * package installs properly * debuginfo package looks complete. * rpmlint is silent. * final provides and requires are sane: XS.so()(64bit) perl(File::MMagic::XS) = 0.08 perl-File-MMagic-XS = 0.08-2.fc6 = perl(:MODULE_COMPAT_5.8.8) perl(File::MMagic) perl(strict) perl(vars) * %check is present and all tests pass: All tests successful. Files=2, Tests=11, 0 wallclock secs ( 0.06 cusr + 0.01 csys = 0.07 CPU) * no shared libraries are added to the regular linker search paths. * package is not relocatable. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no libtool .la droppings. APPROVED Built. |