Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 206816

Summary:	Review Request: freedoom-freedm - Deathmatch levels for freedoom
Product:	[Fedora] Fedora	Reporter:	Wart <wart>
Component:	Package Review	Assignee:	Jason Tibbitts <j>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Package Reviews List <fedora-package-review>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2006-09-23 16:40:23 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	163779

Description Wart 2006-09-16 22:59:14 UTC

Spec URL: http://www.kobold.org/~wart/fedora/freedoom-freedm.spec
SRPM URL: http://www.kobold.org/~wart/fedora/freedoom-freedm-0.5-1.src.rpm
Description: 
Multiplayer deathmatch levels for freedoom

Comment 1 Jason Tibbitts 2006-09-23 04:35:27 UTC

The source URL is failing for me; it's probably some sourceforge breakage.  I
specified a mirror (superb-west.dl.sourceforge.net) and it came through fine.

* source files match upstream:
   340a3e884729c22f45ff73353e2cc67a  freedoom-freedm-0.5.zip
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible.  License text included in package.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly
* rpmlint is silent.
* final provides and requires are sane:
   freedoom-freedm = 0.5-1.fc6
  =
   freedoom
   prboom
* package is not relocatable.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* game levels are acceptable content.
* documentation is small, so no -docs subpackage is necessary.
* desktop file is properly installed.

APPROVED

Comment 2 Wart 2006-09-23 06:51:23 UTC

I also tend to have problems downloading from sourceforge via curl or wget,
using various forms of the download URLs.  I haven't seen a perfect solution to
that problem yet.

Imported and built.  Thanks for the review!