Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 206877
| Summary: | Review Request: bzr-gtk - Bazaar plugin for GTK+ interfaces to most Bazaar operations | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Warren Togami <wtogami> | ||||
| Component: | Package Review | Assignee: | Paul F. Johnson <paul> | ||||
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Package Reviews List <fedora-package-review> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | frank | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2006-12-28 10:23:45 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 163779 | ||||||
| Attachments: |
|
||||||
|
Description
Warren Togami
2006-09-17 16:32:17 UTC
rpmlint stuff...
-src.rpm
E: bzr-gtk description-line-too-long
W: mixed use of spaces and tabs (ignore)
noarch.rpm
Lots of errors due to non-executable-script
(start %{_libdir}/python2.4/site-packages/bzrlib/plugins/gtk/viz)
__init__.py 0644, bzrkapp.py
(start %{_libdir}/python2.4/site-packages/bzrlib/plugins/gtk/)
__init__.py 0644, graphcell.py 0644, graph.py 0644, diffwin.py 0644,
branchwin.py 0644
Spec file looks okay
building now in mock
E: bzr-gtk non-executable-script /usr/lib/python2.4/site-packages/bzrlib/plugins/gtk/viz/__init__.py 0644 Does this really need to be executable? And how rpmlint seeing this as different from the many other py files that it isn't complaining about? http://togami.com/~warren/fedora/bzr-gtk-0.10.0-2.src.rpm http://togami.com/~warren/fedora/bzr-gtk.spec Created attachment 136493 [details]
New spec file
This spec file addresses every warning and error rpmlint was throwing up on my
buildsys. It builds cleanly in mock.
Making the permissions on those scripts 755 seems to be not needed at all. Most of similar installed files have 644 permissions, and this software works fine. These scripts are not meant to be run directly. Do we really need to do this? Just remove the shebang (#!/usr/bin/python) from __init__.py to get rid of this rpmlint error. Maybe you can convince upstream to do the same, if it's really not needed. Requesting approval of the package in #3 which fixes the .src.rpm rpmlint warnings. The opinion of fedora-extras-list is the permission issues are not a problem at all. Removal of shebang is not required either. Okay. Review: Spec file in US-English Consistent use of macros Contains docs upstream and package md5sums match the software installs and deinstalls cleanly no dupes in the rpms contains a %clean section builds cleanly in mock rpmlint gives plenty of warnings and errors, but they can be ignored follows python packaging guidelines APPROVED Could you please close this bug if it has been imported? |