Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 207141
| Summary: | Review Request: farsight - A audio/video conferencing framework | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Brian Pepple <bdpepple> |
| Component: | Package Review | Assignee: | Kevin Fenzi <kevin> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | guillaume.desmottes |
| Target Milestone: | --- | Flags: | j:
fedora-cvs+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2006-09-24 05:19:17 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 163779 | ||
|
Description
Brian Pepple
2006-09-19 17:43:11 UTC
OK - Package name
OK - Spec file matches base package name.
OK - Meets Packaging Guidelines.
See below - License (GPL)
See below - License field in spec matches
See below - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
68daa710087201064680fd02c8a4951a farsight-0.1.8.tar.gz
68daa710087201064680fd02c8a4951a farsight-0.1.8.tar.gz.1
OK - Package compiles and builds on at least one arch.
OK - BuildRequires correct
OK - Spec has needed ldconfig in post and postun
OK - Package owns all the directories it creates.
OK - Package has no duplicate files in %files.
OK - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
OK - Spec has consistant macro usage.
OK - Package is code or permissible content.
OK - Packages %doc files don't affect runtime.
OK - Headers/static libs in -devel subpackage.
OK - .pc files in -devel subpackage.
OK - .so files in -devel subpackage.
OK - -devel package Requires: %{name} = %{version}-%{release}
OK - .la files are removed.
OK - Package doesn't own any directories other packages own.
OK - No rpmlint output.
SHOULD Items:
See below - Should include License or ask upstream to include it.
OK - Should build in mock.
(fc6 {i386|x86_64})
Issues:
1. Is the License LGPL or GPL? The spec says GPL, but the COPYING file
is the LGPL, and all the source files refer to LGPL.
2. Are all the disables needed? Or could some of them be enabled
if other packages were in extras?
--disable-sequence-diagrams \
--disable-sofia-sip \
--disable-gnet \
--disable-msnwebcam \
--disable-yahoowebcam \
3. rpmlint says:
W: farsight-devel no-documentation
which can be ignored.
(In reply to comment #1)> > Issues: > > 1. Is the License LGPL or GPL? The spec says GPL, but the COPYING file > is the LGPL, and all the source files refer to LGPL. Package should be LGPL. > 2. Are all the disables needed? Or could some of them be enabled > if other packages were in extras? > --disable-sequence-diagrams \ > --disable-sofia-sip \ > --disable-gnet \ > --disable-msnwebcam \ > --disable-yahoowebcam \ The disables are currently needed, since most of the other plugins are currently experimental, or in need of a port to their respective new API. ok. Change the spec to have License: LGPL and this package is APPROVED. Package Change Request ====================== Package Name: farsight New Branches: OLPC2 Updated Fedora Owners: gdesmott,bpepple CVS done. BTW, the branch is "OLPC-2"; confused me for a bit. |