Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 207292

Summary:	Review Request: ruby-racc - LALR(1) Parser Generator
Product:	[Fedora] Fedora	Reporter:	David Lutterkort <lutter>
Component:	Package Review	Assignee:	Kevin Fenzi <kevin>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Package Reviews List <fedora-package-review>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	hbrock
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2006-10-09 22:07:41 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	163779

Description David Lutterkort 2006-09-20 15:01:45 UTC

Spec URL: http://people.redhat.com/dlutter/yum/spec/ruby-racc.spec
SRPM URL: http://people.redhat.com/dlutter/yum/SRPMS/ruby-racc-1.4.5-2.src.rpm
Description: 

Racc is Ruby yACC. It is written in Ruby and generates ruby code.
Now almost all functions of yacc are implemented.

Comment 1 Kevin Fenzi 2006-09-23 05:48:04 UTC

OK - Package name
OK - Spec file matches base package name.
OK - Meets Packaging Guidelines.
OK - License (LGPL)
OK - License field in spec matches
OK - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
c23ee98abe79f051243adf04d4a82900  racc-1.4.5-all.tar.gz
c23ee98abe79f051243adf04d4a82900  racc-1.4.5-all.tar.gz.1
OK - Package compiles and builds on at least one arch.
OK - BuildRequires correct
OK - Package owns all the directories it creates.
OK - Package has no duplicate files in %files.
See below - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
OK - Spec has consistant macro usage.
OK - Package is code or permissible content.
OK - Packages %doc files don't affect runtime.
OK - Package doesn't own any directories other packages own.
OK - No rpmlint output.

SHOULD Items:

OK - Should include License or ask upstream to include it.
OK - Should build in mock.
(fc6 {i386|x86_64})

Issues:

1. Minor issue: Might change:
%defattr(-,root,root)
to
%defattr(-,root,root,-)

Otherwise it looks good, so this package is APPROVED.
Don't forget to close this bug as NEXTRELEASE once it's been imported and 
built.

Comment 2 Kevin Fenzi 2006-10-08 04:29:45 UTC

Ping David: Looks like this package has not yet been imported/built. 
Do you still wish to maintain it?

Comment 3 David Lutterkort 2006-10-09 22:07:41 UTC

I imported this package now - sorry for the delay, I was preoccupied with some
other things.