Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 2074406
| Summary: | Review Request: golang-github-a8m-envsubst - Environment variables substitution for Go | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Julien Rische <jrische> |
| Component: | Package Review | Assignee: | Maxwell G <maxwell> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | maxwell, package-review |
| Target Milestone: | --- | Flags: | maxwell:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2022-07-05 14:32:22 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 2074467 | ||
|
Description
Julien Rische
2022-04-12 07:58:14 UTC
Re-generate spec file using go2rpm: Spec URL: https://pagure.io/rpm-golang-github-a8m-envsubst/raw/rawhide/f/golang-github-a8m-envsubst.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/jrische/golang-github-a8m-envsubst/fedora-rawhide-x86_64/04561932-golang-github-a8m-envsubst/golang-github-a8m-envsubst-1.3.0-1.fc37.src.rpm Fedora review: https://download.copr.fedorainfracloud.org/results/jrische/golang-github-a8m-envsubst/fedora-rawhide-x86_64/04561932-golang-github-a8m-envsubst/fedora-review/review.txt I am not going to go through the whole fedora-review template, as this package uses go2rpm. For standard packages (or if you're a newer packager), you should go through the whole template. - [x] The specfile is sane. - [x] License is correct - [x] Builds successfully in mock - [!] Package is installable See below - [x] All rpmlint errors are trivial - [x] %check section passes - [x] The latest version is packaged - [x] `%goipath` is set correctly - [!] Binaries don't conflict with binaries already in the distribution /usr/bin/envsubst conflicts with gettext. I would recommend renaming the binary to goenvsubst or something else so that this doesn't cause conflicts. At least on my system, it is uninstallable, because gettext is required by grub and multiple other packages. Here is a patch[1] to fix the issue. - [!] The package complies with the Packaging Guidelines. - [!] Package does not use globs in `%files` for shared directories [1]: https://paste.sr.ht/~gotmax23/7e204a3cf40d507a68d7cbc4fc0877a798979a47 I renamed the executable file "goenvsubst" and removed the glob in the %files section. Spec URL: https://pagure.io/rpm-golang-github-a8m-envsubst/raw/rawhide/f/golang-github-a8m-envsubst.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/jrische/golang-github-a8m-envsubst/fedora-rawhide-x86_64/04583595-golang-github-a8m-envsubst/golang-github-a8m-envsubst-1.3.0-1.fc37.src.rpm Fedora review: https://download.copr.fedorainfracloud.org/results/jrische/golang-github-a8m-envsubst/fedora-rawhide-x86_64/04583595-golang-github-a8m-envsubst/fedora-review/review.txt Thanks, Julien. I have approved your package and sponsored you into the packager group! Look out for an email from me about how to import your package into Fedora, along with some other pertinent information. (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-a8m-envsubst FEDORA-2022-f8f69a2e43 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-f8f69a2e43 FEDORA-2022-8104e059ec has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-8104e059ec FEDORA-2022-53fdc3a7d3 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-53fdc3a7d3 FEDORA-2022-f8f69a2e43 has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2022-53fdc3a7d3 has been pushed to the Fedora 35 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-53fdc3a7d3 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-53fdc3a7d3 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2022-8104e059ec has been pushed to the Fedora 36 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-8104e059ec \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-8104e059ec See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2022-3969b64d4b has been pushed to the Fedora 35 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-3969b64d4b` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-3969b64d4b See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2022-8104e059ec has been pushed to the Fedora 36 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2022-3969b64d4b has been pushed to the Fedora 35 stable repository. If problem still persists, please make note of it in this bug report. |