Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 2074412
| Summary: | Review Request: golang-github-elliotchance-orderedmap - An ordered map in Go with O(1) for Set, Get, Delete and Len | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Julien Rische <jrische> |
| Component: | Package Review | Assignee: | Mark E. Fuller <mark.e.fuller> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | mark.e.fuller, package-review |
| Target Milestone: | --- | Flags: | mark.e.fuller:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2022-07-18 10:13:22 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 2074467 | ||
|
Description
Julien Rische
2022-04-12 08:03:52 UTC
Re-generate spec file using go2rpm: Spec URL: https://pagure.io/rpm-golang-github-elliotchance-orderedmap/raw/rawhide/f/golang-github-elliotchance-orderedmap.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/jrische/golang-github-elliotchance-orderedmap/fedora-rawhide-x86_64/04561933-golang-github-elliotchance-orderedmap/golang-github-elliotchance-orderedmap-2.0.1-1.fc37.src.rpm Fedora review: https://download.copr.fedorainfracloud.org/results/jrische/golang-github-elliotchance-orderedmap/fedora-rawhide-x86_64/04561933-golang-github-elliotchance-orderedmap/fedora-review/review.txt Standard autogenerated go spec/package
Approved
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
===== MUST items =====
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: There is no build directory. Running licensecheck on vanilla
upstream sources. Licenses found: "Unknown or generated", "MIT
License". 15 files have unknown license. Detailed output of
licensecheck in /home/fuller/fedora-review/2074412-golang-github-
elliotchance-orderedmap/licensecheck.txt
[-]: Package does not own files or directories owned by other packages.
...
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
Note: gpgverify is not used.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic:
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.
Rpmlint
-------
Clean
Source checksums
----------------
https://github.com/elliotchance/orderedmap/archive/v2.0.1/orderedmap-2.0.1.tar.gz :
CHECKSUM(SHA256) this package : f36ec28d800108dbee05ed8731ca614734c90e7d3e215b8d5f13e2b3451fc1a5
CHECKSUM(SHA256) upstream package : f36ec28d800108dbee05ed8731ca614734c90e7d3e215b8d5f13e2b3451fc1a5
Requires
--------
golang-github-elliotchance-orderedmap-devel (rpmlib, GLIBC filtered):
go-filesystem
golang(golang.org/x/exp/constraints)
Provides
--------
golang-github-elliotchance-orderedmap-devel:
golang(github.com/elliotchance/orderedmap)
golang(github.com/elliotchance/orderedmap/v2)
golang-github-elliotchance-orderedmap-devel
golang-ipath(github.com/elliotchance/orderedmap)
Generated by fedora-review 0.8.0 (e988316) last change: 2022-04-07
Command line :/usr/bin/fedora-review -b 2074412
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api
Disabled plugins: Perl, SugarActivity, C/C++, Python, fonts, R, PHP, Haskell, Ocaml, Java
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-elliotchance-orderedmap I'm struggling to build this package for aarch64 and s390x[1]: some performance tests are failing. It's surprising because both were built successfully on Copr[2] some time ago. These tests don't seem to have consistent results, a test that passed might be failing on next run. What should I do in this case? [1] https://koji.fedoraproject.org/koji/taskinfo?taskID=89453649 [2] https://copr.fedorainfracloud.org/coprs/jrische/golang-github-elliotchance-orderedmap/build/4561933/ You could put in an ExcludeArch for the time being I hope you resolve this soon - I am actually looking to use this package as well FEDORA-2022-44c237e9cc has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-44c237e9cc FEDORA-2022-44c237e9cc has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2022-0bc8f1fe14 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-0bc8f1fe14 FEDORA-2022-0bc8f1fe14 has been pushed to the Fedora 36 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-0bc8f1fe14 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-0bc8f1fe14 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2022-0bc8f1fe14 has been pushed to the Fedora 36 stable repository. If problem still persists, please make note of it in this bug report. |