Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 2074463
| Summary: | Review Request: golang-gopkg-op-logging-1 - Golang logging library | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Julien Rische <jrische> |
| Component: | Package Review | Assignee: | Maxwell G <maxwell> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | maxwell, package-review |
| Target Milestone: | --- | Flags: | maxwell:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2022-07-13 16:47:50 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 2074467 | ||
|
Description
Julien Rische
2022-04-12 09:29:59 UTC
Re-generate spec file using go2rpm: Spec URL: https://pagure.io/rpm-golang-gopkg-op-logging-1/raw/rawhide/f/golang-gopkg-op-logging.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/jrische/golang-gopkg-op-logging-1/fedora-rawhide-x86_64/04561929-golang-gopkg-op-logging-1/golang-gopkg-op-logging-1-1-1.fc37.src.rpm Fedora review: https://download.copr.fedorainfracloud.org/results/jrische/golang-gopkg-op-logging-1/fedora-rawhide-x86_64/04561929-golang-gopkg-op-logging-1/fedora-review/review.txt Note that the version 2 of op-logging is already packaged[1], but is not compatible[2] with version 1. Version 1 is required by yq (bug 2074467). [1] https://src.fedoraproject.org/rpms/golang-github-op-logging [2] https://pkg.go.dev/github.com/op/go-logging#section-readme Please regenerate this specfile with `go2rpm -f https://github.com/op/go-logging -v 1 gopkg.in/op/go-logging.v1`. You can look at `go2rpm --help` to see what those options actually do :). Hi Maxwell, I regenerated the spec file using the forge parameter: Spec URL: https://pagure.io/rpm-golang-gopkg-op-logging-1/raw/rawhide/f/golang-gopkg-op-logging-1.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/jrische/golang-gopkg-op-logging-1/fedora-rawhide-x86_64/04597574-golang-gopkg-op-logging-1/golang-gopkg-op-logging-1-1-1.fc37.src.rpm Fedora review: https://download.copr.fedorainfracloud.org/results/jrische/golang-gopkg-op-logging-1/fedora-rawhide-x86_64/04597574-golang-gopkg-op-logging-1/fedora-review/review.txt I am not going to go through the whole fedora-review template, as this package uses go2rpm. - [x] The specfile is sane. - [x] License is correct - [x] Builds successfully in mock - [x] Package is installable (checked by fedora-review) - [x] No relevant rpmlint errors - [x] %check section passes - [-] The latest version is packaged This is a compat package. - [x] `%goipath` is set correctly - [-] Binaries don't conflict with binaries already in the distribution - [x] The package complies with the Packaging Guidelines. Small nitpick: If you'd like, you can also remove the numbers from Source0 and Patch0 (sed -e 's|Source0:|Source: |' -e 's|Patch0:|Patch: |' -i golang-gopkg-op-logging-1.spec) [1]. RPM has supported automatic source/patch file numbering since 4.15.x. The source numbers are not referenced anywhere in this specfile, so I don't see any good reason to keep them. I also submitted a PR to go2rpm to fix this. [1]: The extra spaces are to keep the standard specfile indentation. --- Package approved! On import, don't forget to do the following: (I did the first three steps for you for your first two packages) - [-] Add package to release-monitoring.org by doing. Normally, you'd want to do this, but we can skip this step for this specific package, as it's a compat package which deliberately does not include the latest version. Here are the steps for when you actually have to: * Go to https://release-monitoring.org/ and login. * Click add project in the navbar * Fill in the project name. You can use the upstream name or the Fedora package name here. * Fill in the homepage. This can be the project's website or just the Github page. * Select Github as the backend (or whatever is appropriate). * Select semantic as the Verison scheme. * Fill in owner/project * If it's a go project or another project that prefixes its tags with `v`, add that to Version prefix. * Select Check latest release on submit * Set the Distro to Fedora and put the name of the source package in Package. * Click the Test check button and make sure everything looks correct before submitting. - [ ] Add package to Koschei. 1. Go to https://koschei.fedoraproject.org and log in 2. Click on your username in the top right corner and click the `Add packages` button in the dropdown 3. Put the name of the source package (golang-gopkg-op-logging-1) in the names box and click `Add packages`. The previous two tasks can be done any time, but the next two can only be done after the repo request goes through. - [ ] Give go-sig privileges on package 1. Go to https://src.fedoraproject.org/rpms/golang-gopkg-op-logging-1/addgroup 2. Put `go-sig` in the group name field and give it `commit` access. You can also add me as an admin if you'd like, but you don't have to for this package. - [ ] Close the review bug by referencing it in the rpm changelog and the Bodhi ticket. This is the same thing you did for your other two packages. Thanks! (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-gopkg-op-logging-1 FEDORA-2022-f0cd65f7e6 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-f0cd65f7e6 FEDORA-2022-f0cd65f7e6 has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2022-be00d52700 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-be00d52700 FEDORA-2022-deeebc98af has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-deeebc98af FEDORA-2022-be00d52700 has been pushed to the Fedora 36 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-be00d52700 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-be00d52700 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2022-deeebc98af has been pushed to the Fedora 35 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-deeebc98af \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-deeebc98af See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2022-be00d52700 has been pushed to the Fedora 36 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2022-deeebc98af has been pushed to the Fedora 35 stable repository. If problem still persists, please make note of it in this bug report. |