Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 208453
Summary: | Review Request: php-pear-Console-Getargs - Command-line arguments and parameters parser | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Remi Collet <fedora> |
Component: | Package Review | Assignee: | Jason Tibbitts <j> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | Flags: | petersen:
fedora-cvs+
|
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2006-10-02 06:36:57 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779 |
Description
Remi Collet
2006-09-28 17:41:19 UTC
I wonder if "pear run-tests -p Console_Getargs" is supposed to do anything. I can't actually get it to do anything for any installed PEAR module (other than "Running 0 tests"). * source files match upstream: 67b5918343fa24f3e311d159e168b5dc Console_Getargs-1.3.1.tgz * package meets naming and packaging guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is correct. * license field matches the actual license. * license is open source-compatible. License text included in package. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (development, x86_64). * package installs properly * rpmlint is silent. * final provides and requires are sane: php-pear(Console_Getargs) = 1.3.1 php-pear-Console-Getargs = 1.3.1-1.fc6 = /bin/sh /usr/bin/pear php >= 4.1.0 php-pear(PEAR) * %check is not present; not possible to run the tests within rpm. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * scriptlets are OK (pear install) * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. APPROVED > I wonder if "pear run-tests -p Console_Getargs" is supposed to do anything.
> I can't actually get it to do anything for any installed PEAR module
> (other than "Running 0 tests").
pear run-tests only work when test suite is provided upstream as .phpt files.
For example "pear run-tests -p Log". Must be run by root :(
Some packages (like this one) use PHPUnit, others use PHPUnit2 as a test suite.
I've worked a little on including test in %check without success.
I'll propose PHPUnit for review (even if PHPUnit2 already in Extras).
Package Change Request ====================== Package Name: php-pear-Console-Getargs New Branches: EL-5 done |