Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 2089886 (mctc-lib)

Summary: Review Request: mctc-lib - Modular computation tool chain library
Product: [Fedora] Fedora Reporter: Susi Lehtola <susi.lehtola>
Component: Package ReviewAssignee: Mark E. Fuller <mark.e.fuller>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: mark.e.fuller, package-review
Target Milestone: ---Flags: mark.e.fuller: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2022-06-26 01:18:50 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 2089880    
Bug Blocks: 2086950    

Description Susi Lehtola 2022-05-24 16:09:55 UTC
Spec URL: https://jussilehtola.fedorapeople.org/mctc-lib.spec
SRPM URL: https://jussilehtola.fedorapeople.org/mctc-lib-0.3.0-1.fc36.src.rpm
Fedora Account System Username: jussilehtola

Description:
Common tool chain for working with molecular structure data in various
applications. This library provides a unified way to perform
operations on molecular structure data, like reading and writing to
common geometry file formats.

This library is a dependency of xtb 6.5.0.

Comment 1 Mark E. Fuller 2022-05-31 18:02:14 UTC
Package failed to build on all rawhide architectures:
https://copr.fedorainfracloud.org/coprs/fuller/test-builds/build/4460674/
e.g. https://download.copr.fedorainfracloud.org/results/fuller/test-builds/fedora-rawhide-x86_64/04460674-mctc-lib/builder-live.log.gz
"""
Running custom install script '/builddir/build/BUILD/mctc-lib-0.3.0/config/install-mod.py include/mctc-lib/gcc-12.1.1'
--- stdout ---

--- stderr ---
/usr/bin/env: ‘python’: No such file or directory
"""

Comment 3 Mark E. Fuller 2022-06-14 18:05:52 UTC
Conditionally approved with the use of the %_fmoddir macro 



Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

Issues:
=======
- Please use the %_fmoddir macro to eliminate "Note: No known owner of /usr/lib64/gfortran"


===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: ldconfig not called in %post and %postun for Fedora 28 and later.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[!]: Package requires other packages for directories it uses.
     Note: No known owner of /usr/lib64/gfortran
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[!]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[x]: Reviewer should test that the package builds in mock.
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Patches link to upstream bugs/comments/lists or are otherwise
     justified.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[-]: Packages should try to preserve timestamps of original installed
     files.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: The placement of pkgconfig(.pc) files are correct.
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: There are rpmlint messages (see attachment).
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.


Rpmlint
-------
Cannot parse rpmlint output:


Rpmlint (debuginfo)
-------------------
Cannot parse rpmlint output:



Rpmlint (installed packages)
----------------------------
Cannot parse rpmlint output:


Source checksums
----------------
https://github.com/grimme-lab/mctc-lib/archive/v0.3.0/mctc-lib-0.3.0.tar.gz :
  CHECKSUM(SHA256) this package     : a697516bae03573e9ee43b8b72160584b35cc902e8f35c6024260241b154ec47
  CHECKSUM(SHA256) upstream package : a697516bae03573e9ee43b8b72160584b35cc902e8f35c6024260241b154ec47


Requires
--------
mctc-lib (rpmlib, GLIBC filtered):
    libc.so.6()(64bit)
    libgfortran.so.5()(64bit)
    libgfortran.so.5(GFORTRAN_10)(64bit)
    libgfortran.so.5(GFORTRAN_8)(64bit)
    libjsonfortran.so.8.3()(64bit)
    libm.so.6()(64bit)
    libmctc-lib.so.0()(64bit)
    rtld(GNU_HASH)

mctc-lib-devel (rpmlib, GLIBC filtered):
    /usr/bin/pkg-config
    libmctc-lib.so.0()(64bit)
    mctc-lib(x86-64)
    pkgconfig(json-fortran)

mctc-lib-debuginfo (rpmlib, GLIBC filtered):

mctc-lib-debugsource (rpmlib, GLIBC filtered):



Provides
--------
mctc-lib:
    libmctc-lib.so.0()(64bit)
    mctc-lib
    mctc-lib(x86-64)

mctc-lib-devel:
    mctc-lib-devel
    mctc-lib-devel(x86-64)
    pkgconfig(mctc-lib)

mctc-lib-debuginfo:
    debuginfo(build-id)
    libmctc-lib.so.0.3.0-0.3.0-2.fc37.x86_64.debug()(64bit)
    mctc-lib-debuginfo
    mctc-lib-debuginfo(x86-64)

mctc-lib-debugsource:
    mctc-lib-debugsource
    mctc-lib-debugsource(x86-64)



Generated by fedora-review 0.8.0 (e988316) last change: 2022-04-07
Command line :/usr/bin/fedora-review --no-colors --prebuilt --rpm-spec --name mctc-lib --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api, C/C++
Disabled plugins: Python, SugarActivity, PHP, R, Java, Perl, fonts, Ocaml, Haskell
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH

Comment 4 Susi Lehtola 2022-06-15 19:53:07 UTC
Thanks for the review! %{_fmoddir} macro now used

https://jussilehtola.fedorapeople.org/mctc-lib.spec
https://jussilehtola.fedorapeople.org/mctc-lib-0.3.0-3.fc36.src.rpm

Comment 5 Gwyn Ciesla 2022-06-15 21:32:46 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/mctc-lib

Comment 6 Fedora Update System 2022-06-17 01:49:12 UTC
FEDORA-2022-b10de3e0a5 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-b10de3e0a5

Comment 7 Fedora Update System 2022-06-17 01:49:13 UTC
FEDORA-2022-f3613e08ab has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-f3613e08ab

Comment 8 Fedora Update System 2022-06-18 01:24:46 UTC
FEDORA-2022-f3613e08ab has been pushed to the Fedora 35 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-f3613e08ab \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-f3613e08ab

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 9 Fedora Update System 2022-06-18 01:40:19 UTC
FEDORA-2022-b10de3e0a5 has been pushed to the Fedora 36 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-b10de3e0a5 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-b10de3e0a5

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 10 Fedora Update System 2022-06-26 01:18:50 UTC
FEDORA-2022-b10de3e0a5 has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 11 Fedora Update System 2022-06-26 01:18:52 UTC
FEDORA-2022-f3613e08ab has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.