Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 209261
| Summary: | Review Request: beryl-settings - Beryl OpenGL window and compositing manager GUI config utility | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jarod Wilson <jarod> |
| Component: | Package Review | Assignee: | Michał Bentkowski <mr.ecik> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | alcapcom, chitlesh, fedora, gauret, lmacken |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2006-11-21 21:05:39 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 209259 | ||
| Bug Blocks: | 163779 | ||
|
Description
Jarod Wilson
2006-10-04 06:18:12 UTC
Just uploaded -2 build to remedy duplicate menu entries. http://wilsonet.com/packages/beryl/beryl-settings-0.1.0-2.fc6.src.rpm new beryl-settings installs .desktop menu entries twice /usr/share/applications/beryl-settings.desktop /usr/share/applications/fedora-beryl-settings.desktop Ugh. Really fixed this time. Only partially implemented the fix last go around. http://wilsonet.com/packages/beryl/beryl-settings-0.1.0-3.fc6.src.rpm $ rpm -qpl /build/RPMS/x86_64/beryl-settings-0.1.0-3.fc6.x86_64.rpm |grep desktop /usr/share/applications/fedora-beryl-settings.desktop /usr/share/pixmaps/beryl-settings-section-showdesktop.svg Just pushed out a 0.1.1-1 build: http://wilsonet.com/packages/beryl/beryl-settings-0.1.1-1.fc6.src.rpm chitlesh[0]$rpm -qf /usr/bin/beryl-settings beryl-settings-0.1.1-2.fc6 chitlesh[0]$cat /usr/share/applications/fedora-beryl-settings.desktop [Desktop Entry] Encoding=UTF-8 Name=Beryl Settings Manager Comment=Configure beryl Icon=/usr/share/pixmaps/beryl-settings.png Exec=beryl-settings Terminal=false Type=Application Categories=Settings;X-Fedora; X-Desktop-File-Install-Version=0.10 chitlesh[0]$ls /usr/share/pixmaps/beryl-settings.png ls: /usr/share/pixmaps/beryl-settings.png: No such file or directory Hence no icon on kmenu ! Hrm, I somehow never noticed that... The beryl-settings source tree has nothing but svg graphics files, looks like s/png/svg/ in the .desktop file should fix that. Okay, -3 spec and srpm pushed. Latest build uses upstream tarballs, since they're finally creating them (well, for at least some bits...): http://wilsonet.com/packages/beryl/beryl-settings-0.1.2-2.fc6.src.rpm MUST items: * rpmlint is quiet * package is named well * spec file name is good * package meets Packaging Guidelines * package is licensed with a GPL open-source compatible license * License field in spec file matches actual license * license file is included in %doc * md5sums are matching (882aac1837f92dc20b92927900a917f3) * package successfully compiles on x86_64 * BuildRequires listed well (mock builds succesfully) * spec file handles locales properly * proper %post and %postun sections * not relocatable * package owns directories well * no duplicates in %files * every %files section includes %defattr * proper %clean section * macros used well * .desktop file is present and looks good :) Another beryl approved package :) |