Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 209617
Summary: | Review Request: comix - A user-friendly, customizable image viewer | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Mamoru TASAKA <mtasaka> |
Component: | Package Review | Assignee: | Jason Tibbitts <j> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | pahan |
Target Milestone: | --- | Flags: | huzaifas:
fedora-cvs+
|
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2006-10-07 04:07:56 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779 |
Description
Mamoru TASAKA
2006-10-06 12:51:39 UTC
Note: rpmlint says: W: comix non-conffile-in-etc /etc/gconf/schemas/comix.schemas However, this is not a configuration file and files under /etc/gconf/schemas are usually not marked as %config ( as you can see these files in epiphany. yelp, planner, etc) Hmm, the source doesn't match upstream. Ahh, because the source URL gives me some HTML for selecting a mirror. You should use dl.sourceforge.net instead of prdownloads.sourceforge.net. I also had to manually add a mirror (easynews) in order to actually download the source, since the sourceforge mirror system is so broken. The non-conffile-in-etc bit is known to be bogus for gconf schemas. This package owns /etc/gconf, which is owned by GConf in FC5 but which is completely unowned in FC6. Ouch. This package also owns /etc/gconf/schemas, which unfortunately doesn't seem to be owned by GConf as it should. I really don't know what this package should do; I guess owning those directories is better than leaving them unowned, but this should be fixed in Core and if it is this package will need to stop owning those directories. So I'll approve this package for FC6/rawhide, but for FC5 you will need to stop owning /etc/gconf. * source files match upstream: 2d6034c5c032fcb5fe257048d64364a8 comix-3.6.tar.gz * package meets naming and packaging guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is correct. * license field matches the actual license. * license is open source-compatible. License text included in package. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (development, x86_64). * package installs properly * rpmlint has only bogus complaints. * final provides and requires are sane: comix = 3.6-1.fc6 = /bin/sh /usr/bin/env /usr/bin/jpegtran GConf2 pygtk2 python-imaging * %check is not present; no test suite upstream. Package manually tested and seems to work fine. * owns the directories it creates. ? owns /etc/gconf; in FC5, it must not. * no duplicates in %files. * file permissions are appropriate. * scriptlets are OK (gconf schema installation, icon cache update, desktop database update, mime database update) * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * .desktop file installed properly APPROVED Thank you for a quick review and approving this package!! * Rebuild for FE-devel succeeded. * SyncNeeded is requested for FE-5. Now I close this bug as CLOSED NEXTRELEASE. (In reply to comment #2) > You should use dl.sourceforge.net instead of > prdownloads.sourceforge.net. I changed URL as you recommended. > This package owns /etc/gconf, which is owned by GConf in FC5 but which is > completely unowned in FC6. Ouch. Well, I checked FC5, however, /etc/gconf is not owned by GConf2 (I have not checked GConf because this package does not require GConf) and.. /etc/gconf is not owned by any packages required by this package in FC5, either. So I have to make this package own /etc/gconf in FC5, too (I strongly think that some other package should own /etc/gconf and /etc/gconf/schemas) > This package also owns /etc/gconf/schemas, > which unfortunately doesn't seem to be owned by GConf as it should. This is the same for FC5. Package Change Request ====================== Package Name: comix New Branches: F-10 Owners: mtasaka Early branching request. cvs done |