Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at

Bug 209894

Summary: Review Request: python-eyed3 - Python module for processing ID3 tags
Product: [Fedora] Fedora Reporter: Brian Pepple <bdpepple>
Component: Package ReviewAssignee: Patrice Dumas <pertusus>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Package Reviews List <fedora-package-review>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: i
Target Milestone: ---Flags: gwync: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2006-10-10 21:57:28 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On:    
Bug Blocks: 163779, 794971    

Description Brian Pepple 2006-10-07 16:22:21 UTC
Spec URL:
SRPM URL: Description: A Python module and program for processing ID3 tags. Information about mp3 files(i.e bit rate, sample frequency, play time, etc.) is also provided.  The formats supported are ID3 v1.0/v1.1 and v2.3/v2.4.

Comment 1 Patrice Dumas 2006-10-07 16:53:53 UTC
* as it is a noarch package it may be better to have
BuildRequires:  python
  instead of
BuildRequires:  python-devel

* you could remove the -f option of rm such that it
  breaks if the file isn't there anymore

* You could add README.html and THANKS to %doc

* the build is done twice since make triggers the build
  and the install target depends on all. So I think the
  make in %build should be removed or commented out with a 
  comment indicating that install triggers the build 

* I think that it would be better to have a * for man files
  to catch man pages when no compressed or compressed using 
  something different than gz, like

* Given that it only creates the directory in python_sitelib,
  you may optionally set
instead of

These issues are not blockers.

Comment 2 Patrice Dumas 2006-10-07 17:13:58 UTC
Shouldn't the name be python-eyeD3? 

* rpmlint is silent
* follow packaging guidelines
* spec legible
* free software, licence GPL included
* sane provides
python-eyed3 = 0.6.10-1
* match upstream source
2f7ee6749b993faba3b5d10d9621d314  ./eyeD3-0.6.10.tar.gz
* %files right
* buildrequires/requires right

The only remaining issue is the name.

Comment 3 Brian Pepple 2006-10-07 17:26:54 UTC
(In reply to comment #2)
> Shouldn't the name be python-eyeD3? 

It's up to the maintainers discretion.  I based the name on how other distros
package it also.

Comment 4 Patrice Dumas 2006-10-07 17:48:15 UTC


But please take into consideration my comments, even though they aren't 

Comment 5 Patrice Dumas 2006-10-09 10:14:30 UTC
It seems to be built in devel and added to owners.list, please
don't forget to close the review.

Comment 6 Brian Pepple 2006-10-09 12:50:47 UTC
I'm aware, but I'm waiting for the FC5 branch to be created before closing this.

Comment 7 Christopher Meng 2013-12-22 04:31:54 UTC
Package Change Request
Package Name: python-eyed3
New Branches: el6
Owners: cicku

Comment 8 Gwyn Ciesla 2013-12-23 12:53:38 UTC
Git done (by process-git-requests).

Comment 9 Fedora Update System 2013-12-28 06:19:28 UTC
python-eyed3-0.7.4-1.el6 has been submitted as an update for Fedora EPEL 6.

Comment 10 Fedora Update System 2014-01-12 19:19:23 UTC
python-eyed3-0.7.4-1.el6 has been pushed to the Fedora EPEL 6 stable repository.

Comment 11 Christopher Meng 2014-01-20 03:38:02 UTC
Package Change Request
Package Name: python-eyed3
New Branches: epel7
Owners: cicku

Comment 12 Gwyn Ciesla 2014-01-21 13:49:06 UTC
Git done (by process-git-requests).