Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 210320

Summary:	Review Request: perl-File-BaseDir - Use the freedesktop basedir spec
Product:	[Fedora] Fedora	Reporter:	Patrice Dumas <pertusus>
Component:	Package Review	Assignee:	Jason Tibbitts <j>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Package Reviews List <fedora-package-review>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	mmaslano, orion
Target Milestone:	---	Flags:	gwync: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2006-10-17 21:31:49 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	210323
Bug Blocks:	163779, 210322

Description Patrice Dumas 2006-10-11 15:28:20 UTC

Spec URL: http://www.environnement.ens.fr/perso/dumas/fc-srpms/perl-File-BaseDir.spec
SRPM URL: http://www.environnement.ens.fr/perso/dumas/fc-srpms/perl-File-BaseDir-0.02-1.src.rpm
Description: 

This module can be used to find directories and files as specified by the
XDG Base Directory Specification. It takes care of defaults and uses
File::Spec to make the output platform specific.

Comment 1 Jason Tibbitts 2006-10-14 16:40:54 UTC

Looks like the dependencies are a bit messed up.

Comment 2 Jason Tibbitts 2006-10-14 20:43:23 UTC

I put perl-File-DesktopEntry in a local repo so I could get through this faster.

* source files match upstream:
  00e2729f364d430350355250cb9007e0  File-BaseDir-0.02.tar.gz
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible.  License text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly
* rpmlint is silent.
* final provides and requires are sane:
   perl(File::BaseDir) = 0.02
   perl-File-BaseDir = 0.02-1.fc6
  =
   perl(:MODULE_COMPAT_5.8.8)
   perl(Carp)
   perl(Exporter)
   perl(File::Spec)
   perl(strict)
* %check is present and all tests pass:
   All tests successful.
   Files=1, Tests=5,  0 wallclock secs ( 0.01 cusr +  0.02 csys =  0.03 CPU)
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

APPROVED

Comment 3 Patrice Dumas 2006-10-17 21:31:49 UTC

Thanks for the quick review.

Built in FC5, devel, owner added.

Comment 4 Orion Poplawski 2012-12-11 17:14:03 UTC

I'd like to see this in EPEL6.  I can maintain it there if needed.

Comment 5 Marcela Mašláňová 2012-12-12 14:15:45 UTC

Feel free to take it for EPEL.

Comment 6 Orion Poplawski 2012-12-12 15:36:44 UTC

Thanks for the response.

Package Change Request
======================
Package Name: perl-File-BaseDir
New Branches: el6
Owners: orion
InitialCC:

Comment 7 Gwyn Ciesla 2012-12-12 15:37:49 UTC

Git done (by process-git-requests).