Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 210323
| Summary: | Review Request: perl-File-DesktopEntry - Object to handle .desktop files | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Patrice Dumas <pertusus> |
| Component: | Package Review | Assignee: | Jason Tibbitts <j> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | michael, paul |
| Target Milestone: | --- | Flags: | gwync:
fedora-cvs+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2006-10-17 21:32:21 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 163779, 210320, 210322 | ||
|
Description
Patrice Dumas
2006-10-11 15:34:15 UTC
I was looking at the spec and then at: http://fedoraproject.org/wiki/Packaging/Perl and your spec doesnt have the provides stuff mentioned at the top, I wasnt sure if thats because it wasnt needed here or what. It does build fine in mock and rpmlint has nothing to say about it. If you refer to the requires and provides autodeps, it is only needed when package autodetected provides or requires are wrong. Those of the one I proposed seem right: Provides: perl(File::DesktopEntry) = 0.02 Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(VersionedDependencies) <= 3.0.3-1 Requires: perl(:MODULE_COMPAT_5.8.8) perl(File::Spec) perl(strict) Michael, everything on http://fedoraproject.org/wiki/Packaging/Perl is either advisory or contingent on the faulure of some part of RPM's automatic dependency generation. RPM actually does a pretty good job of figuring out most Perl dependencies, and the resulting packages don't generally need much in the way of extraneous bits. * source files match upstream: 9c97efa062c04bcb86a0a6a3707355d1 File-DesktopEntry-0.02.tar.gz * package meets naming and packaging guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is correct. * license field matches the actual license. * license is open source-compatible. License text not included upstream. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (development, x86_64). * package installs properly * rpmlint is silent. * final provides and requires are sane: perl(File::DesktopEntry) = 0.02 perl-File-DesktopEntry = 0.02-1.fc6 = perl(:MODULE_COMPAT_5.8.8) perl(File::Spec) perl(strict) * %check is present and all tests pass: All tests successful. Files=2, Tests=10, 0 wallclock secs ( 0.06 cusr + 0.03 csys = 0.09 CPU) * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. APPROVED Thanks for that review too. Package Change Request ====================== Package Name: perl-File-DesktopEntry New Branches: el6 Owners: pghmcfc ktdreyer InitialCC: perl-sig I (pghmcfc) am already the owner of this package in EPEL-7. Git done (by process-git-requests). perl-File-DesktopEntry-0.08-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/perl-File-DesktopEntry-0.08-1.el6 perl-File-DesktopEntry-0.08-1.el6 has been pushed to the Fedora EPEL 6 stable repository. |