Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 210632

Summary:	Review Request: fbg - Falling Block Game
Product:	[Fedora] Fedora	Reporter:	Hans de Goede <hdegoede>
Component:	Package Review	Assignee:	Michał Bentkowski <mr.ecik>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Package Reviews List <fedora-package-review>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2006-10-14 11:47:39 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	163779

Description Hans de Goede 2006-10-13 13:47:05 UTC

Spec URL: http://people.atrpms.net/~hdegoede/fbg.spec
SRPM URL: http://people.atrpms.net/~hdegoede/fbg-0.9-1.fc6.src.rpm
Description:
Move and rotate variously shaped falling blocks to make them form a complete
row. Once a complete row has formed it will disappear. If you make
incomplete rows the screen will fill up and when it reaches the top the game
is over.

Comment 1 Michał Bentkowski 2006-10-13 14:56:02 UTC

MUST items:
 * rpmlint doesn't show anything
 * package is named well
 * spec file name is good
 * package meets Packaging Guidelines
 * package is licensed with an GPL open-source compatible license
 * License field in spec file doesn't match actual license
 * license file is included in %doc
 * md5sums are matching (82db64d84b6172f5676fcff69d533881)
 * package successfully compiles on x86_64
 * BuildRequires listed well (mock builds fine)
 * no locales
 * proper %post and %postun sections
 * not relocatable
 * package owns directories well
 * no duplicates in %files
 * every %files section includes %defattr
 * proper %clean section
 * macros used well
 * .desktop file is present

THINGS to do:
 * change spec's License field to GPL

Fix thing mentioned above and package will be approved,

Comment 2 Hans de Goede 2006-10-14 06:49:06 UTC

Woops, good catch. I used a spec from a previous package for this and that
stayed in.

Here is a version with the license tag fixed:
Spec URL: http://people.atrpms.net/~hdegoede/fbg.spec
SRPM URL: http://people.atrpms.net/~hdegoede/fbg-0.9-2.fc6.src.rpm

Comment 3 Michał Bentkowski 2006-10-14 10:08:26 UTC

You haven't updated a spec file but a SRPM looks good.

So package is APPROVED.

Comment 4 Hans de Goede 2006-10-14 11:47:39 UTC

Oops, you're right I forgot to upload the spec. Thanks for looking at the SRPM.
I've imported and build the correct/updated srpm, closing.

Thanks!